Skip to content

docs: update room substruct spec after PR 0 + PR A#2069

Merged
rgbkrk merged 1 commit intomainfrom
docs/room-substructs-spec-update
Apr 23, 2026
Merged

docs: update room substruct spec after PR 0 + PR A#2069
rgbkrk merged 1 commit intomainfrom
docs/room-substructs-spec-update

Conversation

@rgbkrk
Copy link
Copy Markdown
Member

@rgbkrk rgbkrk commented Apr 23, 2026

Reflects shipped state (PR #2061 deletions, PR #2064 RoomIdentity). Drops the RoomDocState substruct per D1. Updates field counts against post-#2065 code. Reshapes remaining plan as three atomic per-substruct PRs (RoomBroadcasts, RoomPersistence, RoomConnections) instead of the original scaffolding-then-migrate split — Rust can't fake field access via methods, so one atomic PR per substruct is cleaner.

~89 callsites remaining across the three PRs.

Reflect shipped state (PR 0 + RoomIdentity), drop the RoomDocState
substruct (D1 rationale: doc stays top-level), update field counts
against post-#2065 code, and reshape the migration path as three
atomic per-substruct PRs instead of the original scaffolding-then-
migrate split (Rust can't fake field access via methods).

Target is now three PRs: RoomBroadcasts, RoomPersistence,
RoomConnections. ~89 callsites remaining across them.
@github-actions github-actions Bot added the documentation Improvements or additions to documentation label Apr 23, 2026
@rgbkrk rgbkrk merged commit 02825ea into main Apr 23, 2026
22 checks passed
@rgbkrk rgbkrk deleted the docs/room-substructs-spec-update branch April 23, 2026 05:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant