Add daemon support for code completions (Tab/Ctrl+Space)#328
Merged
Conversation
rgbkrk
force-pushed
the
quill/workspace-review
branch
from
644d4c6 to
5f0c838
Compare
Implement code completion requests via the daemon using the Jupyter protocol's complete_request/complete_reply messages. Uses LSP-ready CompletionItem structure for future extensibility with additional completion sources (ruff, basedpyright). Closes #314.
rgbkrk
force-pushed
the
quill/workspace-review
branch
from
6af5d5f to
f701f38
Compare
rgbkrk
added
quill
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements code completion requests via the daemon using the Jupyter protocol's
complete_request/complete_replymessages. Uses LSP-readyCompletionItemstructure for future extensibility with additional completion sources (ruff, basedpyright). Follows the same request/response pattern as the history search feature (PR #320).The frontend invokes
complete_via_daemon()when the user triggers autocompletion (Ctrl+Space or after typing.), which sends aCompleterequest to the daemon. The kernel manager tracks pending requests and converts kernel matches toCompletionItemobjects before returning results.Closes #314
Verification
.)PR submitted by @rgbkrk's agent, Quill