Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds comprehensive test coverage for the mdextract package. The changes include new test cases for previously untested functions (parseTag, parseFileTag), additional test cases for existing test functions, and enables coverage reporting in the test command.
Changes:
- Added tests for unexported helper functions (parseTag, parseFileTag)
- Added error path tests and edge case tests for Extract and ExtractFromFile methods
- Enhanced Makefile test target to include coverage reporting with
-coverflag - Added t.Parallel() to all existing test functions for consistent parallel execution
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| pkg/mdextract/single_test.go | Added 4 new test functions covering parseTag, error handling, table-driven tests for Extract, and additional AcceptBlock cases |
| pkg/mdextract/multi_test.go | Added t.Parallel() to existing tests, added new test cases to TestParseFileTag, and added 3 new test functions for comprehensive multi-file extraction testing |
| Makefile | Added -cover flag to test command to enable coverage reporting |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: Nelo-T. Wallus <red.brush9525@fastmail.com>
Signed-off-by: Nelo-T. Wallus <red.brush9525@fastmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.