-
Notifications
You must be signed in to change notification settings - Fork 49
Add features for Gadolinium neutron capture #32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hi @nickwp, This all looks good to me. I just have one question: you copied over the ANNRI Gd capture model -- does this mean this model is public? If we add it to the WCSim code it will become available to the world, since WCSim is open source. If this is a problem we can find a way around it, such as hosting the ANNRI code in a private repository under the NuPRISM organization, for example. Cheers, |
|
Hi Cris, Yes, sorry, I think this code should not be public. I had actually not realised that the nuPRISM WCSim was public, but in any case it doesn't matter since my own fork is also public, and the commit is already there. I will have to rebase my branch, remove the commits, and force the push to my github fork, to make sure it is removed entirely rather than still available in the history. I'm not sure how this will affect this pull request, but if needed I'll close this and create a new one. For now I think it's best to just leave out the ANNRI code, if we need to add it in future we can use your solution with a private repository. Thanks, |
|
Hi Cris, I've performed the rebase and all seems fine with the ANNRI code removed. Thanks, |
This pull request includes: