Move standard_tracer's subscription observer to cpp#562
Move standard_tracer's subscription observer to cpp#562MatthieuDartiailh merged 13 commits intonucleic:mainfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #562 +/- ##
==========================================
- Coverage 70.92% 70.91% -0.01%
==========================================
Files 287 287
Lines 25710 25698 -12
Branches 3643 3641 -2
==========================================
- Hits 18234 18224 -10
Misses 6385 6385
+ Partials 1091 1089 -2 🚀 New features to boost your workflow:
|
27b4454 to
51e0a8f
Compare
MatthieuDartiailh
left a comment
There was a problem hiding this comment.
I made several suggestions to simplify your handling of reference counts. I tested locally and it works but feel free to give it another spin.
Could you also add a changelog entry ?
|
Thanks for the review. I tried moving the whole standard_tracer to cpp here but this branch actually faster somehow so I think it's better to just go with this branch as it's also much simpler. |
|
Can you rebase on main to get the CI to pass ? |
This is unexpected but I will take your word for it. No reason to add more cpp if there is no real gain. |
Co-authored-by: Matthieu Dartiailh <marul@laposte.net>
be40300 to
dda8fa8
Compare
|
I was able to get the poor example in #561 even faster by moving all the PyImport_ImportModule into the modexec (from ~16sec to ~12sec). |
|
I’d like to review the c++ code before this is merged.
…On Tue, Jan 7, 2025 at 13:33 frmdstryr ***@***.***> wrote:
I was able to get it event faster by moving all the PyImport_ImportModule
into the modexec.
—
Reply to this email directly, view it on GitHub
<#562 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABBQSI6F46AQ37WUIBTFKD2JQTY7AVCNFSM6AAAAABUVUII22VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKNZWGA3TMOBZGA>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
|
Sure, @sccolbert , I will wait for your approval before merging. |
ae99c93 to
b061af8
Compare
|
The original example now runs in 9 seconds, down from the original 50 seconds. |
|
That's a really nice improvement ! |
Moves the subscription observer in standard_tracer.py to cpp.
This gives a considerable performance increase if there are a lot of changes going on (~60%) but for most code it will likely only be a small improvement. My application sped up about 30% (even after fixing the original problem).
Ref #561