chore: OSS housekeeping round 2#30
Merged
Merged
Conversation
- Delete build_release.sh: leaked Robusta GCP project (us-central1-docker.pkg.dev/genuine-flight-317411/devel/kubewatch) and DockerHub repo (robustadev/kubewatch). Image publishing now lives in .github/workflows/build.yaml targeting GHCR. - Delete build_with_arm.sh: defunct local-only helper; build.yaml handles multi-arch builds via docker buildx. - Makefile: replace Travis-era TRAVIS_COMMIT env var with GIT_COMMIT, add VERSION ldflag injection so 'make build' produces a binary that reports its version like the Docker-built image does. - Add CODE_OF_CONDUCT.md: reference-only adoption of Contributor Covenant 2.1 with reporting address and pointer to SECURITY.md for vulnerabilities.
There was a problem hiding this comment.
Code Review
This pull request adds a Code of Conduct, updates the Makefile to support versioning and generic git commit variables, and removes several Docker build scripts. Feedback was provided regarding the Makefile to use the $(shell ...) function for variable assignments instead of backticks to improve robustness and error handling when git is unavailable.
RamanKharchee
approved these changes
May 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Second pass of OSS-prep cleanup, addressing items found in a manual review of the repo:
build_release.sh— leaked Robusta-internal GCP project (us-central1-docker.pkg.dev/genuine-flight-317411/devel/kubewatch) and DockerHub repo (robustadev/kubewatch). Image publishing now lives in.github/workflows/build.yamltargeting GHCR.build_with_arm.sh— defunct local-only helper; the workflow handles multi-arch builds viadocker buildx.TRAVIS_COMMITenv var (Travis was removed earlier) withGIT_COMMIT. AddVERSIONldflag injection somake buildproduces a binary that reports its version viakubewatch version, matching what the Docker-built image does.CODE_OF_CONDUCT.md— reference-only adoption of Contributor Covenant 2.1 with reporting address and pointer toSECURITY.mdfor vulnerabilities.Tests performed
go build ./...cleanmake build VERSION=v0.0.0-testwill injectversion=v0.0.0-test,gitCommit=$(git describe --tags),buildDate=<now>grep -rn 'robustadev\|genuine-flight\|robusta-charts' .returns nothing after this PRCODE_OF_CONDUCT.mdis reference-only and links to the canonical Contributor Covenant text rather than embedding itNotes for reviewers
CHANGELOG.md was considered but skipped —
softprops/action-gh-releasealready auto-generates per-tag release notes on tag push, making a static CHANGELOG.md duplicate work that goes stale.go.mod module path stays as
github.com/bitnami-labs/kubewatchintentionally — renaming would break anyone consuming the upstream import path. Not critical for OSS release.