Skip to content

chore: OSS housekeeping round 2#30

Merged
mayankpande88 merged 1 commit into
masterfrom
chore/oss-housekeeping-round2
May 13, 2026
Merged

chore: OSS housekeeping round 2#30
mayankpande88 merged 1 commit into
masterfrom
chore/oss-housekeeping-round2

Conversation

@mayankpande88
Copy link
Copy Markdown
Contributor

Summary

Second pass of OSS-prep cleanup, addressing items found in a manual review of the repo:

  • Delete build_release.sh — leaked Robusta-internal GCP project (us-central1-docker.pkg.dev/genuine-flight-317411/devel/kubewatch) and DockerHub repo (robustadev/kubewatch). Image publishing now lives in .github/workflows/build.yaml targeting GHCR.
  • Delete build_with_arm.sh — defunct local-only helper; the workflow handles multi-arch builds via docker buildx.
  • Makefile cleanup — replace Travis-era TRAVIS_COMMIT env var (Travis was removed earlier) with GIT_COMMIT. Add VERSION ldflag injection so make build produces a binary that reports its version via kubewatch version, matching what the Docker-built image does.
  • Add CODE_OF_CONDUCT.md — reference-only adoption of Contributor Covenant 2.1 with reporting address and pointer to SECURITY.md for vulnerabilities.

Tests performed

  • go build ./... clean
  • Manually inspected new Makefile by tracing the LDFLAGS expansion: make build VERSION=v0.0.0-test will inject version=v0.0.0-test, gitCommit=$(git describe --tags), buildDate=<now>
  • Confirmed no other build scripts reference Robusta infrastructure: grep -rn 'robustadev\|genuine-flight\|robusta-charts' . returns nothing after this PR
  • CODE_OF_CONDUCT.md is reference-only and links to the canonical Contributor Covenant text rather than embedding it

Notes for reviewers

CHANGELOG.md was considered but skipped — softprops/action-gh-release already auto-generates per-tag release notes on tag push, making a static CHANGELOG.md duplicate work that goes stale.

go.mod module path stays as github.com/bitnami-labs/kubewatch intentionally — renaming would break anyone consuming the upstream import path. Not critical for OSS release.

- Delete build_release.sh: leaked Robusta GCP project
  (us-central1-docker.pkg.dev/genuine-flight-317411/devel/kubewatch)
  and DockerHub repo (robustadev/kubewatch). Image publishing now
  lives in .github/workflows/build.yaml targeting GHCR.
- Delete build_with_arm.sh: defunct local-only helper; build.yaml
  handles multi-arch builds via docker buildx.
- Makefile: replace Travis-era TRAVIS_COMMIT env var with GIT_COMMIT,
  add VERSION ldflag injection so 'make build' produces a binary
  that reports its version like the Docker-built image does.
- Add CODE_OF_CONDUCT.md: reference-only adoption of Contributor
  Covenant 2.1 with reporting address and pointer to SECURITY.md
  for vulnerabilities.
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds a Code of Conduct, updates the Makefile to support versioning and generic git commit variables, and removes several Docker build scripts. Feedback was provided regarding the Makefile to use the $(shell ...) function for variable assignments instead of backticks to improve robustness and error handling when git is unavailable.

Comment thread Makefile
@mayankpande88 mayankpande88 merged commit 5cd8113 into master May 13, 2026
3 checks passed
@mayankpande88 mayankpande88 deleted the chore/oss-housekeeping-round2 branch May 14, 2026 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants