Skip to content

feat: added workflow validation#34

Merged
blue4209211 merged 1 commit into
mainfrom
workflow_validate
Jan 4, 2026
Merged

feat: added workflow validation#34
blue4209211 merged 1 commit into
mainfrom
workflow_validate

Conversation

@blue4209211

@blue4209211 blue4209211 commented Jan 4, 2026

Copy link
Copy Markdown
Contributor

added workflow validate subcommand

@gemini-code-assist

Copy link
Copy Markdown

Summary of Changes

Hello @blue4209211, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances the nbctl command-line interface by adding a new feature for validating workflow definitions. It provides a dedicated command to check the correctness of workflow YAML files against the Nudgebee backend, improving the developer experience by offering immediate feedback and detailed error reporting. The changes also include internal refactorings to support this new functionality and improve testing consistency.

Highlights

  • New workflow validate Command: Introduced a new CLI command nbctl workflow validate [file] that allows users to validate a workflow YAML file against the Nudgebee API. This command reads the YAML, injects the account ID if missing, and sends a GraphQL mutation request for validation.
  • Enhanced Error Handling: The new validation command includes sophisticated error parsing, specifically designed to drill down into nested Hasura GraphQL errors (e.g., ActionWebhookErrorResponse) to extract and present more user-friendly and actionable error messages from the backend.
  • Authenticated HTTP Client: A new NewHTTPClient function has been added to pkg/client to create authenticated http.Client instances. This client handles API key/username authentication and endpoint configuration, including optional verbose logging, and is utilized by the workflow validation logic.
  • CLI Experience Improvement: The root Cobra command (nbctl) has been configured with SilenceErrors: true and SilenceUsage: true to prevent Cobra from printing default error messages and usage information, leading to a cleaner and more controlled output for the user.
  • Testing Utilities Refactor: The WithViper helper function, used for temporarily setting Viper configurations in tests, has been moved from pkg/testutil to pkg/config for better organization. Additionally, client.ResetClient() was added to RunWithMockServer to ensure a fresh client instance for each test run.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a new workflow validate subcommand to validate workflow definition files. It also includes several refactorings in the test and client packages to support this new functionality. The changes look good overall, adding valuable functionality. I've left a few comments on areas that could be improved for better maintainability and robustness, mainly concerning code duplication in the client setup and complex error parsing logic in the new command. Addressing these points will make the codebase cleaner and more resilient to future changes.

Comment thread cmd/workflow_validate.go
Comment thread cmd/workflow_validate.go
Comment thread pkg/client/client.go
Comment thread cmd/workflow_validate.go
Comment thread cmd/workflow_validate.go
@blue4209211 blue4209211 merged commit 741ceb1 into main Jan 4, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants