chore: main to test#141
Conversation
# Conflicts: # ebpftracer/ebpf.go
ebpf: improve protocol identification accuracy
instance metadata: add support for Alibaba Cloud
Add version flag and installation of specific version
add support for hybrid cgroup mode with both V1 and V2 enabled
instance metadata: add support for Scaleway
application types: add OpenSearch and VictoriaMetrics
containers: invalidate ignored containers cache
group connections to AWS services by FQDN instead of IPs
application types: add Coroot
enhance accuracy of cgroup2 base path detection
…ation tls: avoid reading the entire `.text` section to reduce memory allocations (#175)
fix detection of actual destination for TCP connections
using FQDNs as destinations when they are resolved into a list of public IPs
…sing improve error handling in ClickHouse protocol parser
chore: rebase upstream
Bumps [github.com/cilium/cilium](https://github.com/cilium/cilium) from 1.17.2 to 1.17.3. - [Release notes](https://github.com/cilium/cilium/releases) - [Changelog](https://github.com/cilium/cilium/blob/1.17.3/CHANGELOG.md) - [Commits](cilium/cilium@1.17.2...1.17.3) --- updated-dependencies: - dependency-name: github.com/cilium/cilium dependency-version: 1.17.3 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
…m/cilium/cilium-1.17.3 build(deps): bump github.com/cilium/cilium from 1.17.2 to 1.17.3
remove usage of Prometheus WAL
add GPU metrics
prometheus: avoid retaining compression buffer between iterations
chore: rebase with upstream
chore: updated log parser
chore: added az/region metric for bytes transferred
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @mayankpande88, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request introduces significant new capabilities, including GPU monitoring and enhanced JVM profiling. It also improves the agent's compatibility and configurability through refined cgroup handling, container filtering options, support for additional cloud providers, and a more robust Prometheus remote write mechanism with data spooling. Various dependencies have also been updated.
Highlights
- GPU Metrics Collection: Added support for collecting NVIDIA GPU usage, memory, temperature, and power metrics at both the node and process levels. This provides visibility into GPU resource consumption by individual containers.
- Improved Cgroup Handling: Refactored cgroup detection and parsing logic to better support cgroup v1 and v2 in various environments, including handling different mount points and container runtimes like Docker, containerd, and crio, and recognizing
reserved.slice. - Container Filtering: Introduced new flags (
--container-allowlist,--container-denylist) to allow users to specify which containers the agent should monitor using regex patterns. - New Cloud Provider Metadata: Added detection and collection of instance metadata for Alibaba Cloud, Scaleway, and IBM Cloud, enhancing node information in these environments. Also allows overriding discovered metadata via flags.
- JVM Perfmap Dumping: Implemented functionality to trigger perfmap dumps in JVM processes configured with
-XX:+PreserveFramePointer, improving symbol resolution for Java profiling. - Prometheus Remote Write Spooling: Added an on-disk spool for metrics data sent via Prometheus remote write, ensuring data is buffered and not lost during temporary network or endpoint unavailability.
- Enhanced Network Metrics: Added source and destination region and availability zone labels to network bytes sent/received metrics, providing better geographical context for network traffic analysis.
- Expanded Application Detection: Improved application type detection by adding recognition for Coroot components, OpenSearch, Ollama, VictoriaMetrics, VictoriaLogs, and Ruby, using both command line and executable path analysis.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configureGemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request introduces several significant features and improvements, including GPU monitoring, Prometheus remote write support, JVM perfmap dumping for enhanced profiling, and more robust cgroup v1/v2 handling. It also adds container filtering capabilities and various smaller enhancements and bug fixes across the codebase. The changes generally improve the agent's feature set, robustness, and configurability. The PR title and description could be more descriptive of the changes included.
chore: fix for high cves
6 participants
No description provided.