chore: oss-readiness follow-ups: DeepFlow NOTICE, manifest image tag, DCO policy#260
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the contribution guidelines to clarify that no DCO or CLA is required, adds a copyright attribution notice for techniques borrowed from the DeepFlow project, and updates the node agent image tag in the Kubernetes manifest. The reviewer noted that the copyright attribution in the NOTICE file should refer to "Yunshan Networks" instead of "DeepFlow, Inc." to ensure legal accuracy.
…ings socket_info.c and gotls.c self-describe as based on DeepFlow's approach; acknowledge DeepFlow (https://github.com/deepflowio/deepflow), Copyright Yunshan Networks, Apache-2.0, alongside the Coroot attribution.
The manifest pinned :1, which was never published to GHCR (only v0.1.0 exists -> tags 0, 0.1, 0.1.0) and would ImagePullBackOff. Pin to the fully qualified semver :0.1.0 per the manifest's own production guidance.
mayankpande88
force-pushed
the
oss-readiness-followups
branch
from
704fcc4 to
bbf7761
Compare
blue4209211
changed the title
blue4209211
approved these changes
May 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-ups from the pre-public-release audit. Three independent commits so any can be dropped on its own.
676d222— DeepFlow attribution in NOTICE (#5)ebpftracer/ebpf/socket_info.candebpftracer/ebpf/l7/gotls.cself-describe as "based on / following DeepFlow's approach". These are technique borrowings (not verified copied source), but the in-code references warrant a courtesy acknowledgment. Added a DeepFlow line (Apache-2.0) to NOTICE next to the Coroot attribution. If any DeepFlow source was actually copied, this line becomes mandatory under Apache-2.0 §4 — confirm.23082b5— manifest image tag fix (#6)manifests/nudgebee-node-agent.yamlpinnedghcr.io/nudgebee/node-agent:1, but no:1tag exists — the only published release is v0.1.0 (GHCR tags0,0.1,0.1.0). As-is it wouldImagePullBackOff. Repinned to:0. If the OSS debut is cut as v1.0.0, bump this back to:1at release time.836a25c— DCO policy (#8)CONTRIBUTING had no DCO/sign-off statement. Added an explicit "no DCO/CLA required" note. Flip to a sign-off requirement if you'd rather enforce DCO.
Not included (tracked separately): module-path rename (declined — keeps upstream rebase low-friction), Go Report Card badge removal (pending that decision), CHANGELOG dated section (do at tag time), git-history rewrite, branch-protection #10/#11 and security features (at flip).