Skip to content

fix: fix for duplicate stats #61

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
blue4209211 merged 1 commit into from
May 20, 2024
Merged

fix: fix for duplicate stats #61

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 6 additions & 10 deletions containers/container.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@ import (
"github.com/coroot/coroot-node-agent/flags"
"github.com/coroot/coroot-node-agent/logs"
"github.com/coroot/coroot-node-agent/node"
"github.com/coroot/coroot-node-agent/node/metadata"
"github.com/coroot/coroot-node-agent/pinger"
"github.com/coroot/coroot-node-agent/proc"
"github.com/coroot/coroot-node-agent/tracing"
Expand Down Expand Up @@ -141,13 +140,11 @@ type Container struct {

lock sync.RWMutex

done chan struct{}
ip_resolver IPResolver
instanceMetadata *metadata.CloudMetadata
done chan struct{}
ip_resolver IPResolver
}

func NewContainer(id ContainerID, cg *cgroup.Cgroup, md *ContainerMetadata, hostConntrack *Conntrack, pid uint32, ip_resolver IPResolver, instanceMeta *metadata.CloudMetadata) (*Container, error) {
instanceMetadata := instanceMeta
func NewContainer(id ContainerID, cg *cgroup.Cgroup, md *ContainerMetadata, hostConntrack *Conntrack, pid uint32, ip_resolver IPResolver) (*Container, error) {
netNs, err := proc.GetNetNs(pid)
if err != nil {
return nil, err
Expand Down Expand Up @@ -179,9 +176,8 @@ func NewContainer(id ContainerID, cg *cgroup.Cgroup, md *ContainerMetadata, host

hostConntrack: hostConntrack,

done: make(chan struct{}),
ip_resolver: ip_resolver,
instanceMetadata: instanceMetadata,
done: make(chan struct{}),
ip_resolver: ip_resolver,
}

for _, n := range md.networks {
Expand Down Expand Up @@ -696,7 +692,7 @@ func (c *Container) onL7Request(pid uint32, fd uint64, timestamp uint64, r *l7.R
if r.Response != nil {
response = base64.StdEncoding.EncodeToString(r.Response)
}
trace.HttpRequest(method, uri, r.Status, r.Duration, r.PayloadSize, payload, headers, response, host, *c.instanceMetadata, conn.actualDestWorkload)
trace.HttpRequest(method, uri, r.Status, r.Duration, r.PayloadSize, payload, headers, response, host, conn.actualDestWorkload)
case l7.ProtocolHTTP2:
if conn.http2Parser == nil {
conn.http2Parser = l7.NewHttp2Parser()
Expand Down
9 changes: 3 additions & 6 deletions containers/registry.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@ import (
"github.com/coroot/coroot-node-agent/common"
"github.com/coroot/coroot-node-agent/ebpftracer"
"github.com/coroot/coroot-node-agent/flags"
"github.com/coroot/coroot-node-agent/node/metadata"
"github.com/coroot/coroot-node-agent/proc"
"github.com/prometheus/client_golang/prometheus"
"github.com/vishvananda/netns"
Expand Down Expand Up @@ -55,7 +54,6 @@ type Registry struct {

processInfoCh chan<- ProcessInfo
ip_resolver IPResolver
instanceMeta *metadata.CloudMetadata
}

func NewRegistry(reg prometheus.Registerer, kernelVersion string, processInfoCh chan<- ProcessInfo, ip_resolver *common.K8sIPResolver) (*Registry, error) {
Expand Down Expand Up @@ -112,9 +110,8 @@ func NewRegistry(reg prometheus.Registerer, kernelVersion string, processInfoCh

processInfoCh: processInfoCh,

tracer: ebpftracer.NewTracer(kernelVersion, *flags.DisableL7Tracing),
ip_resolver: ip_resolver,
instanceMeta: metadata.GetInstanceMetadata(),
tracer: ebpftracer.NewTracer(kernelVersion, *flags.DisableL7Tracing),
ip_resolver: ip_resolver,
}

go r.handleEvents(r.events)
Expand Down Expand Up @@ -310,7 +307,7 @@ func (r *Registry) getOrCreateContainer(pid uint32) *Container {
r.containersByCgroupId[cg.Id] = c
return c
}
c, err := NewContainer(id, cg, md, r.hostConntrack, pid, r.ip_resolver, r.instanceMeta)
c, err := NewContainer(id, cg, md, r.hostConntrack, pid, r.ip_resolver)
if err != nil {
klog.Warningf("failed to create container pid=%d cg=%s id=%s: %s", pid, cg.Id, id, err)
return nil
Expand Down
6 changes: 4 additions & 2 deletions main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ import (
"github.com/coroot/coroot-node-agent/flags"
"github.com/coroot/coroot-node-agent/logs"
"github.com/coroot/coroot-node-agent/node"
"github.com/coroot/coroot-node-agent/node/metadata"
"github.com/coroot/coroot-node-agent/profiling"
"github.com/coroot/coroot-node-agent/prom"
"github.com/coroot/coroot-node-agent/tracing"
Expand Down Expand Up @@ -148,15 +149,16 @@ func main() {
whitelistNodeExternalNetworks()

machineId := machineID()
tracing.Init(machineId, hostname, version)
md := metadata.GetInstanceMetadata()
tracing.Init(machineId, hostname, version, md)
logs.Init(machineId, hostname, version)

registry := prometheus.NewRegistry()
registerer := prometheus.WrapRegistererWith(prometheus.Labels{"machine_id": machineId}, registry)

registerer.MustRegister(info("node_agent_info", version))

if err := registerer.Register(node.NewCollector(hostname, kv)); err != nil {
if err := registerer.Register(node.NewCollector(hostname, kv, md)); err != nil {
klog.Exitln(err)
}

Expand Down
3 changes: 1 addition & 2 deletions node/collector.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,8 +152,7 @@ type Collector struct {
instanceMetadata *metadata.CloudMetadata
}

func NewCollector(hostname, kernelVersion string) *Collector {
md := metadata.GetInstanceMetadata()
func NewCollector(hostname, kernelVersion string, md *metadata.CloudMetadata) *Collector {
klog.Infof("instance metadata: %+v", md)
return &Collector{
hostname: hostname,
Expand Down
8 changes: 5 additions & 3 deletions tracing/tracing.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,11 +26,13 @@ const (
)

var (
tracer func(containerId string) trace.Tracer
tracer func(containerId string) trace.Tracer
instanceMetadata *metadata.CloudMetadata
)

func Init(machineId, hostname, version string) {
func Init(machineId, hostname, version string, md *metadata.CloudMetadata) {
endpointUrl := *flags.TracesEndpoint
instanceMetadata = md
if endpointUrl == nil {
klog.Infoln("no OpenTelemetry traces collector endpoint configured")
return
Expand Down Expand Up @@ -108,7 +110,7 @@ func (t *Trace) createSpan(name string, duration time.Duration, error bool, attr
span.End(trace.WithTimestamp(end))
}

func (t *Trace) HttpRequest(method, path string, status l7.Status, duration time.Duration, requestSize uint64, payload string, headers string, response string, host string, instanceMetadata metadata.CloudMetadata, destWorkload common.Workload) {
func (t *Trace) HttpRequest(method, path string, status l7.Status, duration time.Duration, requestSize uint64, payload string, headers string, response string, host string, destWorkload common.Workload) {
if t == nil || method == "" {
return
}
Expand Down