Skip to content

Conversation

@HasutoSasaki
Copy link
Contributor

@HasutoSasaki HasutoSasaki commented Aug 5, 2025

Proposal

Implement missing version/milestone management functionality identified in progress.md.

Planned Tools

  • get_version_milestone_list: Retrieve versions/milestones for a project
  • add_version_milestone: Create new versions/milestones
  • update_version_milestone: Update existing versions/milestones
  • delete_version: Delete versions

Implementation Plan

  1. Add 4 new tools with comprehensive tests
  2. Update tools registration in tools.ts

No breaking changes planned.

Planning to implement:
- get_version_milestone_list: retrieve versions/milestones for a project
- add_version_milestone: create new versions/milestones
- update_version_milestone: update existing versions/milestones
- delete_version: delete versions
@trknhr
Copy link
Collaborator

trknhr commented Aug 7, 2025

Thanks for the PR!

Just to confirm. This PR includes only the get_version_milestone_list tool. Is that correct?
Does it contain all the commits you intended to include for this feature?

@HasutoSasaki
Copy link
Contributor Author

@trknhr

Thank you for your message!

Yes, this PR currently includes only the get_version_milestone_list tool.
At this stage, I opened it as a draft to make the progress visible. Once it’s ready for review, I plan to mark it as ready for review (open).
If opening it as a draft was not appropriate in this case, I’m happy to close it and re-open it properly later.

Please let me know what you’d prefer🙇

@HasutoSasaki HasutoSasaki marked this pull request as ready for review August 9, 2025 10:35
@HasutoSasaki
Copy link
Contributor Author

@trknhr
Sorry for the delay. The work is now completed!
Please review when you have time.

Copy link
Collaborator

@trknhr trknhr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update README.md about these tools you created. Thank you.

],
},
{
name: 'version_milestone',
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please move these tools into the issue toolset?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your confirmation! I have moved it to the issue section.
dbabc36

if (!result.ok) {
throw result.error;
}
if (!id) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you elaborate the reason why this check is required. i'm sure that id is required parameter and it doesn't reach to this check point as undefined

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@trknhr
You're absolutely right. I missed that detail. Since id is required in the schema, the check is unnecessary. My apologies for the oversight.

57e9d76

@HasutoSasaki
Copy link
Contributor Author

@trknhr
Sorry, the README has not been updated yet, so please wait a little.

@HasutoSasaki
Copy link
Contributor Author

@trknhr

Sorry for the wait.
Thank you for your review.
We have responded to your review, so please check it out.

#16 (review)

@trknhr trknhr merged commit a11f859 into nulab:main Aug 26, 2025
1 check passed
@trknhr
Copy link
Collaborator

trknhr commented Aug 26, 2025

@HasutoSasaki Thanks. Looks great

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants