-
Notifications
You must be signed in to change notification settings - Fork 36
Add version/milestone management tools #16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Planning to implement: - get_version_milestone_list: retrieve versions/milestones for a project - add_version_milestone: create new versions/milestones - update_version_milestone: update existing versions/milestones - delete_version: delete versions
|
Thanks for the PR! Just to confirm. This PR includes only the |
|
Thank you for your message! Yes, this PR currently includes only the get_version_milestone_list tool. Please let me know what you’d prefer🙇 |
- src/tools/addVersionMilestone.test.ts - src/tools/addVersionMilestone.ts - src/tools/getVersionMilestoneList.test.ts - src/tools/getVersionMilestoneList.ts - src/tools/updateVersionMilestone.test.ts - src/tools/updateVersionMilestone.ts
|
@trknhr |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update README.md about these tools you created. Thank you.
src/tools/tools.ts
Outdated
| ], | ||
| }, | ||
| { | ||
| name: 'version_milestone', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please move these tools into the issue toolset?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your confirmation! I have moved it to the issue section.
dbabc36
src/tools/updateVersionMilestone.ts
Outdated
| if (!result.ok) { | ||
| throw result.error; | ||
| } | ||
| if (!id) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could you elaborate the reason why this check is required. i'm sure that id is required parameter and it doesn't reach to this check point as undefined
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- id parameters are already specified as required in the schema.
|
@trknhr |
|
Sorry for the wait. |
|
@HasutoSasaki Thanks. Looks great |
Proposal
Implement missing version/milestone management functionality identified in
progress.md.Planned Tools
get_version_milestone_list: Retrieve versions/milestones for a projectadd_version_milestone: Create new versions/milestonesupdate_version_milestone: Update existing versions/milestonesdelete_version: Delete versionsImplementation Plan
tools.tsNo breaking changes planned.