Conversation
fe1ae9d to
cdc62ea
Compare
bmquinn
approved these changes
Feb 2, 2026
Contributor
bmquinn
left a comment
There was a problem hiding this comment.
Looks great, though I think extra is a little vague. Approving regardless because I can live with it, but what do you think about provenance or relations instead?
2bca065 to
2ac807b
Compare
2ac807b to
2900549
Compare
kdid
approved these changes
Feb 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for fetching obsolete terms without redirecting, so the old label can be retrieved.
Changes:
Authoritex.RecordandAuthoritex.SearchResultstructs to return instead of bare mapsopts \\ []argument toAuthoritex.fetchto allow for redirection (default: false)http://id.worldcat.org/fast/fst01205331replaced byhttp://id.worldcat.org/fast/1205331despite still being the same term)This will be a MAJOR version update, as it breaks both the calling interface, the shape of the return values, and the redirect behavior:
I am very open to calling the added field something other thanextra. I thought maybeflagsornotes, but couldn't really find one I felt great about.relatedseems much better.First step in fixing repodev_planning_and_docs#5783