feat: Config Sync for Recipe Viewers #27
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Recipe viewer should now use server-side generator config instead of client-side
null2264
added a commit
that referenced
this pull request
May 15, 2023
* feat: Fluid Interaction Overhaul (#23) * feat: Advanced fluid interaction * feat: Wildcard support * chore: Exit early if advanced generator is not configured * chore: Disable advanced generators by default * feat: Allow users to define advanced custom stone generators * chore: Simplify code * chore: Simplify code * feat: Silent generator * refactor: Merge generators * chore: Optimize code * chore: Improving readability * chore: Simplify code * feat: Fluid Interaction API (Big overhaul) REI/EMI/JEI is broken in this commit, because config handler is overhauled to be processed on launch (and `/reload`). This will allow other people to add their own generator with relative ease. * fix: REI/EMI/JEI integration * fix: Pipe always generate cobblestone instead of stone * feat: Built-in plugin for Create mod * refactor: Reformat code * chore: Bump version to 4.0 (ALPHA) * fix: HotFix after Play-test * Empty fluid for all-fluid generators caused issues * Fix Limestone and Scoria generators * Crash caused by null generators * Add 'WeightedBlock.fromBlock' * chore: Bump version to 4.0.1 Also append version stage to modrinth releases * fix: Registrate pain, fixes #26 * fix: More Registrate pain Of course it doesn't work, why would it be * chore: Bump version to 4.0.2 * feat: Config Sync for Recipe Viewers (#27) * feat: PacketByteBuf stuff * feat: Working recipe viewer sync Recipe viewer should now use server-side generator config instead of client-side * feat: Don't use Fabric API * feat: Don't send data to fake players * feat: Only send config when player has recipe viewer installed * chore: Bump version to 4.0.3 * chore: Bump version to 4.0.3 * fix: Oops, messed up git * chore: Switch to SLF4J * fix: Another overhaul another basalt gen bug * fix: Registrate pain (again) Why is this stupid thing keep breaking * chore: Bump version to 4.0.4 * chore: I give up, remove create mod built-in plugin Fluid always return EmptyFluid for some reason. Could be caused by how fabric load mods... idk, whatever i'm done dealing with this stupid thing * chore: Rework on how plugin being registered * chore: Rearrange some stuff * chore: Add helper class * chore: Clean up * chore: Apply CobbleGen late This also make CobbleGen reload everytime you enter a singleplayer world (Probably better for most players anyway) * chore: Bump version to 4.0.5 * chore: Re-added reload Now that I think about it, keep loading json file seems like a bad idea... let's just load it when needed * feat: Sync when server is reloaded * chore: Move PlayerManagerMixin to network directory * chore: Bump jankson version to 1.2.2 * chore: CobbleGen no longer use MixinExtras * chore: Split built-in plugin and plugin for create mod * chore: Clean up gradle Fluid interaction no longer depends on Porting Lib to provide compatibility, so we no longer need to test the mod with and without Create * chore: Polishing logs * chore: Prepare beta release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, recipe viewer (REI/EMI/JEI) always show
cobblegenconfiguration from the player's client config, which means if the server uses a different config recipe viewers will not show it to the player. This PR aims to fix this issue by sending the server's config to the player's client when the server detects a player joining the server and then deleting the config once the player disconnected from the server.