Error when compling on QMK 0.13.19

[sebastiansam55]

I'm running into an error that seems to be related to recent changes made to the QMK repository. Error log is as follows;

QMK Firmware 0.13.19
Making nullbitsco/tidbit with keymap default

avr-gcc (GCC) 5.4.0
Copyright (C) 2015 Free Software Foundation, Inc.
This is free software; see the source for copying conditions.  There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

Compiling: drivers/avr/i2c_master.c                                                                 [OK]
Compiling: keyboards/nullbitsco/tidbit/bitc_led.c                                                   [OK]
Compiling: keyboards/nullbitsco/tidbit/remote_kb.c                                                  [OK]
Compiling: keyboards/nullbitsco/tidbit/tidbit.c                                                     [OK]
Compiling: keyboards/nullbitsco/tidbit/keymaps/default/keymap.c                                    keyboards/nullbitsco/tidbit/keymaps/default/keymap.c:85:6: error: conflicting types for ‘encoder_update_user’
 void encoder_update_user(uint8_t index, bool clockwise) {
      ^
In file included from quantum/quantum.h:204:0,
                 from keyboards/nullbitsco/tidbit/tidbit.h:3,
                 from keyboards/nullbitsco/tidbit/keymaps/default/keymap.c:17:
quantum/encoder.h:26:6: note: previous declaration of ‘encoder_update_user’ was here
 bool encoder_update_user(uint8_t index, bool clockwise);
      ^
 [ERRORS]
 |
 |
 |
make[1]: *** [tmk_core/rules.mk:436: .build/obj_nullbitsco_tidbit_default/keyboards/nullbitsco/tidbit/keymaps/default/keymap.o] Error 1
Make finished with errors
make: *** [Makefile:530: nullbitsco/tidbit:default] Error 1

If you check out the commit history of the encoder.h file you can see that encoder_update_user was switched from returning a void to now returning a bool.

https://github.com/qmk/qmk_firmware/commits/master/quantum/encoder.h

You can also see this reflected in the change log found here https://github.com/qmk/qmk_firmware/pull/13034/files#diff-af2d3d9adab6194cb4cd0b7c61426f10d1e36ade107af2f52d09539fefafdbf1R75

These changes were implemented in the git tag 0.12.52, rolling all the way back to 0.12.51 allows the firmware to build successfully.

If you are following along at home; instead of git cloneing the qmk_firmware repo you can download the 0.12.51 tagged release from this github page and build/flash as normal.

https://github.com/qmk/qmk_firmware/releases/tag/0.12.51

[Freakin]

Exact same issue here. Great summary of the problem.

Literally brand new to QMK and just got my tidbit built an hour ago, but does updating the tidbit function definition override to bool encoder_update_user(uint8_t index, bool clockwise) and adding a return true; at the end of the function work?

edit was able to successfully compile and flash the firmware after changing function definition in keymap.c

bool encoder_update_user(uint8_t index, bool clockwise) {
  /* With an if statement we can check which encoder was turned. */
  if (index == 0) { /* First encoder */
    if (clockwise) {
      tap_code(KC_1);
    } else {
      tap_code(KC_2);
    }
  } else if (index == 1) { /* Second encoder */
    if (clockwise) {
      tap_code(KC_PGUP);
    } else {
      tap_code(KC_PGDN);
    }
  } else if (index == 2) { /* Thrid encoder */
    if (clockwise) {
      tap_code(KC_MPRV);
    } else {
      tap_code(KC_MNXT);
    }
  } else if (index == 3) { /* Forth encoder */
    if (clockwise) {
      tap_code(KC_VOLU);
    } else {
      tap_code(KC_VOLD);
    }  
  }
  return true;
}

[sebastiansam55]

I suspected that would be the case but don't know C that well myself, hopefully it gets patched!

[jaygreco]

This has now been resolved with #9 👍