fix(runtime): load persisted runtime state safely#52
Merged
Conversation
DonPrus
approved these changes
May 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PersistedRuntimeparsed.deinit()Why
Fresh NullHub builds could crash on boot while reconciling persisted managed runtime state. The loader parsed JSON directly into the owned runtime struct and then deinitialized the parser, leaving fields like
binary_pathandlaunch_commandpointing at freed memory. Boot reconciliation then compared those invalid slices and could segfault before the server started.Validation
zig build test -Dbuild-ui=false -Dembed-ui=false/api/statusinstead of crashing during reconcile-on-boot