Do not use echo -e when processing params#3
Merged
patrickcrocker merged 1 commit intonulldriver:masterfrom Sep 19, 2017
Merged
Conversation
Using `echo -e` would expand any escaped character (e.g. newlines: \n) which will result in a invalid json that jq cannot parse, failing with an error like: parse error: Invalid string: control characters from U+0000 through U+001F must be escaped at line 215, column 2 there is no reason to use echo -e, we want to process the raw params.
Member
|
This is shipped in version |
patrickcrocker
pushed a commit
that referenced
this pull request
Mar 20, 2019
Fix service_key extraction from options due to copy paste error.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using
echo -ewould expand any escaped character (e.g. newlines: \n)which will result in a invalid json that jq cannot parse, failing with
an error like:
parse error: Invalid string: control characters from U+0000 through
U+001F must be escaped at line 215, column 2
there is no reason to use echo -e, we want to process the raw params.