fix(generator): handle relative URIs in UriScheme validation#47
Merged
Conversation
Treat non-absolute Uri values as validation failures for UriScheme constraints so invalid URL-like input exits cleanly with code 2 instead of throwing. Add an integration test that reproduces the reported `not-an-url` crash case. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
validate-uri-scheme --endpoint not-an-urlto capture the reported crash pathUriSchemevalidation codegen to treat non-absolute URIs as invalid and avoid reading.Schemeon relative URIsURI scheme must be one of: ...) with clean exit code 2Test plan
dotnet test tests/Nullean.Argh.IntegrationTests/ -c Release --filter \"FullyQualifiedName~ValidationAnnotationTests.UriScheme_\"dotnet run --project tests/Nullean.Argh.Tests.CliHost/ -c Release -- validate-uri-scheme --endpoint not-an-urlMade with Cursor