Skip to content

Devel #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Kazimirkas merged 5 commits into from
Feb 27, 2018
Merged

Devel #19

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
805030a
stripped console from production mode
Kazimirkas Feb 27, 2018
e0f7f99
fixed errors and removed warning
Kazimirkas Feb 27, 2018
38d2218
updated build
Kazimirkas Feb 27, 2018
6068495
eslintrc fix
Kazimirkas Feb 27, 2018
6fa76d6
Merge pull request #18 from nullgr/feature/removeConsoleWarn
Kazimirkas Feb 27, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .eslintrc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@
"keyword-spacing": ["warn", {"after": true}],
"jsx-quotes": ["warn", "prefer-double"],
"no-extra-boolean-cast": "off",
"no-console": 0,
"no-multi-spaces": "warn",
"no-spaced-func": "warn",
"no-unused-vars": "warn",
Expand Down
10 changes: 7 additions & 3 deletions build/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -195,8 +195,11 @@ var Validation = function () {
key: 'isFormValid',
value: function isFormValid(state) {
var storage = state[this.validationStorageName];
if ((typeof state === 'undefined' ? 'undefined' : _typeof(state)) !== 'object') {
throw new Error('Invalid state parameter, must be object');
}
if ((typeof storage === 'undefined' ? 'undefined' : _typeof(storage)) !== 'object') {
throw new Error('Invalid fieldsMappedToStatuses object, must be object');
throw new Error('Invalid storage object, must be object');
}

var keys = Object.keys(storage);
Expand All @@ -219,13 +222,14 @@ var Validation = function () {
key: 'isFieldValid',
value: function isFieldValid(state, fieldName) {
var storage = state[this.validationStorageName];
if ((typeof state === 'undefined' ? 'undefined' : _typeof(state)) !== 'object') {
throw new Error('Invalid state parameter, must be object');
}
if ((typeof storage === 'undefined' ? 'undefined' : _typeof(storage)) !== 'object') {
throw new Error('Invalid storage object, must be object');
}
var fieldStatuses = storage[fieldName];
if (!fieldStatuses) {
// TODO: how to disable warnings in production
console.warn("Attempt to validate field that doesn't exist");
return false;
}

Expand Down
10 changes: 7 additions & 3 deletions src/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -208,8 +208,11 @@ class Validation {

isFormValid(state: Object): boolean {
const storage = state[this.validationStorageName];
if (typeof state !== 'object') {
throw new Error('Invalid state parameter, must be object');
}
if (typeof storage !== 'object') {
throw new Error('Invalid fieldsMappedToStatuses object, must be object');
throw new Error('Invalid storage object, must be object');
}

const keys = Object.keys(storage);
Expand All @@ -228,13 +231,14 @@ class Validation {

isFieldValid(state: Object, fieldName: string): boolean {
const storage = state[this.validationStorageName];
if (typeof state !== 'object') {
throw new Error('Invalid state parameter, must be object');
}
if (typeof storage !== 'object') {
throw new Error('Invalid storage object, must be object');
}
const fieldStatuses = storage[fieldName];
if (!fieldStatuses) {
// TODO: how to disable warnings in production
console.warn("Attempt to validate field that doesn't exist");
return false;
}

Expand Down