docs(arch-and-scope): architecture design, acceptance criteria, and workflow consistency#7
Open
docs(arch-and-scope): architecture design, acceptance criteria, and workflow consistency#7
Conversation
…oduced 9 ADRs, arch_journal.md
…reflect validated 6-module structure
…y-only is malformed
- All 14 features BASELINED (2026-04-22) - Rules + Examples + @id tags written for all features - Fixed FLOW.md: add [STEP-1-BACKLOG-CRITERIA] state and detection rule - Fixed product-owner agent: handle backlog-criteria state without looping - Clarified @id validity in scope_journal (I1a): any non-empty value is valid
…; embed arch Q&A into ADRs; slim discovery.md format
…; transfer update-docs ownership to SA
… skills Root A (issues 3,9,10,11,16,18,20,21): FLOW.md/WORK.md confusion — all session log, state update, and format references corrected to WORK.md (FLOW.md is static and agent-immutable). Root B (issues 1,6,14,19): domain-model.md phantom references removed from AGENTS.md, run-session, verify, system-architect, implement skills; all references now point to ## Domain Model section of docs/system.md. Root C (issues 2,7,8,12,13,15): ownership errors fixed — [STEP-2-READY] owner changed to software-engineer; [POST-MORTEM] action split between PO and SE; [STEP-5-COMPLETE] detection rule 13 added and entry condition disambiguated from [STEP-5-MERGE]; create-skill/SKILL.md implement step corrected to Step 3; system-architect.md create-skill entry removed; implement/SKILL.md test-coverage -> test. Root D (issues 4,5,17): git-release stages docs/system.md not deleted context.md/container.md; architect/SKILL.md template directory fixed to 'this skill's directory'; FLOW.md Source:/Feature: field references replaced with WORK.md @id/@Branch.
i2A: STEP-2-ARCH failure exit changed from STEP-1-DISCOVERY to STEP-1-CRITERIA; a baselined feature with a spec gap needs criteria extended, not rediscovered. i3A: detection rule 10 now checks WORK.md @State = STEP-5-READY before the filesystem test-pass check (rule 11); filesystem alone cannot distinguish Step 4 complete from Step 5 ready, so WORK.md takes precedence for late- pipeline states. i4/5: software-engineer.md No-In-Progress and Spec-Gaps sections corrected to reference WORK.md instead of FLOW.md (FLOW.md is agent-immutable). i6B: IDLE exit now lists all 3 conditional initial states depending on feature content (STEP-1-DISCOVERY / STEP-1-CRITERIA / STEP-2-READY), matching the logic in select-feature skill. i7A: STEP-3-READY and STEP-3-GREEN merged into STEP-3-WORKING; STEP-3-RED retained as a mid-cycle sub-state with a note that WORK.md stays STEP-3-WORKING unless the session ends mid-RED. All STEP-3-READY references in agent files updated to STEP-3-WORKING.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes
docs/adr/— 9 new ADRs covering module structure, slug derivation, adapter protocol, error handling, and moredocs/system.md— domain model, Context, and Container sections merged and expandeddocs/features/backlog/— all 14 feature files with full@id-tagged acceptance criteriadocs/glossary.md— living glossary populated from discovery sessionsdocs/discovery.md,docs/scope_journal.md— updated session recordsdocs/post-mortem/— stage 2 infinite loop post-mortemAGENTS.md,FLOW.md,README.md,WORK.md— workflow consistency and ownership fixespyproject.toml— minor update