fix: align workflow to 5-step diagram with research-backed consistency#65
Merged
fix: align workflow to 5-step diagram with research-backed consistency#65
Conversation
- AGENTS.md: rewrite Step 1 phases with 3-session model (Ph1+Ph2), move decomposition check to after Ph2 Session 3, add INVEST gate to Phase 3, remove final pre-mortem from Phase 4, update TODO.md reference, fix Step 2 description (remove 'get PO approval') - docs/workflow.md: replace Step 1 diagram with full 3-session flow including gap-finding labels (CIT/Laddering/CI Perspective), template enforcement gates, update Feature File Structure example - scope/SKILL.md (v4.0): add gap-finding techniques section, add active listening protocol (3 levels), rewrite Phase 1+2 around 3 sessions each with template gates and pre-mortems at correct positions, update feature and project-level discovery formats - docs/features/discovery.md: expand to full 3-session template - scope/discovery-template.md: expand to full 3-session template - product-owner.md: update skill description to 3-session model
…diagram - Add .opencode/skills/design-patterns/SKILL.md with GoF pattern catalogue, smell-triggered patterns (8 with Python before/after), SOLID, Object Calisthenics, Python Zen, Law of Demeter, CQS, Tell Don't Ask - Update docs/workflow.md Step 2 box: prerequisites, domain analysis, pre-mortem, typed signatures in module structure, informative signature note, architecture smell check as hard gate (9 items incl. pattern smells) - Update docs/workflow.md Step 4 SELF-DECLARE: 24-item first-person format - Update docs/workflow.md TODO.md structure: first-person declaration format - Update implementation/SKILL.md: self-declaration format changed from checkboxes to 'As a developer I declare [rule] — YES | file:line', add 3 design pattern smell items, update reviewer template to match - Update AGENTS.md: add design-patterns skill row (developer, steps 2+4) - Update academic_research.md: entry 42 Hexagonal Architecture (Cockburn 2005), renumber old 42-49 to 43-50, add bibliography entries 65-66
- Rename developer to software-engineer - Steps 3+4 merged into TDD Loop (Steps 2-3) - Steps 5→4 Verify, 6→5 Accept - Remove gen-tests/gen-id/deprecated/tdd skill - Self-declaration: AGREE/DISAGREE | file:line, 24 items, once per feature - Per-test reviewer gate removed - Add software-engineer.md agent - Update all skills and agents to match
- Fix YES/NO → AGREE/DISAGREE in self-declaration - Fix developer → software-engineer role names - Fix 6 steps → 5 steps - Remove gen-tests, gen-id references - Update scope frozen-criteria section - Fix code-quality redirect to verify - Fix design-patterns load trigger step 3 - Fix create-skill available skills table - Delete tdd/ skill (obsolete) - Fix AGENTS.md: step count, role name, duplicate markers, quality gate heading
- Updated create-skill to v2.0 with research basis (Anthropic, OpenAI) - Added new create-agent skill following OpenAI/Anthropic best practices - Added create-agent to AGENTS.md skills table - create-agent is invoked by human-user (not software-engineer)
- create-skill: Step 0 is now research domain, search best practices, synthesize conclusions, embed as guidance - create-agent: Same mandatory research step, scoped to agent's domain + domain methodology - Removed academic citations, embed conclusions as direct actionable guidance
…er → software-engineer
…names, step counts, skills list
…/integration markers
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Aligns the entire repository to the new 5-step workflow diagram with consistent role names, self-declaration format, and research-backed skill/agent creation.
Changes Made
developer→software-engineereverywhereYES/NO→AGREE/DISAGREE(canonical TDD research)tdd/SKILL.mdand brokengen-teststask (merged into implementation)create-skillandcreate-agentskills — agents must research domain best practices before creating new skills/agentsResearch Basis
Files Changed (8 commits)
AGENTS.md— 5 steps, software-engineer role, skills tabledocs/workflow.md— 5-step diagram, AGREE/DISAGREE, updated role tablesREADME.md— 5-step summary, updated skills, aligned commands.opencode/skills/*/SKILL.md— role names, step numbers, self-declaration formatpyproject.toml— removed broken gen-tests task.opencode/skills/create-agent/SKILL.md— research-backed agent creationVerification
All commands pass:
task lint✓task static-check✓task test✓Reviewer Notes
This is a consistency-only change. No functional behavior changes — just alignment to the agreed workflow diagram and research-backed best practices.