Add logging format and tests for k8s/deployment module#148
Merged
Conversation
fedemaleh
force-pushed
the
feature/k8s-deployment-logging-and-tests
branch
from
b00f512 to
335bc8a
Compare
ignacioboud
reviewed
Feb 6, 2026
fedemaleh
force-pushed
the
feature/k8s-deployment-logging-and-tests
branch
from
335bc8a to
a501ca8
Compare
fedemaleh
force-pushed
the
feature/k8s-deployment-logging-and-tests
branch
from
3152fb9 to
98d96b4
Compare
ignacioboud
previously approved these changes
Feb 9, 2026
ignacioboud
approved these changes
Feb 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Scripts Updated (16 total)
k8s/apply_templatesk8s/deployment/build_contextk8s/deployment/build_deploymentk8s/deployment/delete_cluster_objectsk8s/deployment/delete_ingress_finalizerk8s/deployment/kill_instancesk8s/deployment/notify_active_domainsk8s/deployment/print_failed_deployment_hintsk8s/deployment/scale_deploymentsk8s/deployment/verify_http_route_reconciliationk8s/deployment/verify_ingress_reconciliationk8s/deployment/verify_networking_reconciliationk8s/deployment/wait_deployment_activek8s/deployment/networking/gateway/route_traffick8s/deployment/networking/gateway/rollback_traffick8s/deployment/networking/gateway/ingress/route_trafficTest Files Added (17 total)
All tests follow best practices:
Test plan