fix(rds-postgres-server): propagate TFSTATE_BUCKET through link/unlink workflows#12
Merged
sebastiancorrea81 merged 1 commit intomainfrom Apr 21, 2026
Conversation
…k workflows build_permissions_context was reading tfstate_bucket from values.yaml (which never defined it), causing an empty bucket name on terraform init during link and unlink actions. Align with rds-postgres-db pattern: export TFSTATE_BUCKET from build_context via workflow output and consume it from the environment. Added an explicit guard in build_permissions_context to fail fast if the var is missing. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
jcastiarena
approved these changes
Apr 21, 2026
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
build_permissions_contextleíatfstate_bucketdevalues.yaml, pero esa key nunca estuvo definida ahí, dejando el bucket vacío en elterraform initde link/unlinkTFSTATE_BUCKETaloutputdel stepbuild_contextenlink.yamlyunlink.yaml, alineándose con el patrón derds-postgres-dbyaml_valuepor consumo directo de la variable de entorno, con un guard explícito que falla rápido si no está seteadaWhy it didn't fail before
build_permissions_contextsolo corre en workflows delinkyunlink— nunca encreate,updateodelete. Instalaciones que nunca hicieron un link no se vieron afectadas.Test plan
rds-postgres-serverlinky verificar queTFSTATE_BUCKETllega correctamente abuild_permissions_contextterraform initusa el bucket correcto (np-service-<SERVICE_ID>)unlinky verificar el mismo comportamiento🤖 Generated with Claude Code