Crash fix after diff and closing a model#2061
Merged
rkhaotix merged 1 commit intonullptrlabs:git-plugin-prepfrom Mar 13, 2026
Merged
Crash fix after diff and closing a model#2061rkhaotix merged 1 commit intonullptrlabs:git-plugin-prepfrom
rkhaotix merged 1 commit intonullptrlabs:git-plugin-prepfrom
Conversation
Member
|
Hi @darko1979 Thanks for the PR. I fear that the windows stacktrace code is not so efficient to pinpoint problems, compared to the stack trace in Linux and macOS. I tried to write a similar code some weeks ago, but gave up because the returned info was not as detailed as I thought. I'll try another approach in the future. About the crash fix, I'll merge it, but could you please separate it into a different PR? :) |
Author
|
@rkhaotix done. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fix resolves issue #1872 where pgmodeler was crashing after I diff and then trying to close main window.
Also this fixes another crash I started noticing on version 2.0, after opening a model and then trying to close it from menu it will crash pgmodeler.
Fix was copilot assisted and it was hard to trace because it was not reproducible when debugger was attached. So copilot added stack trace for windows (included in second commit) and from that stack trace was able to locate the problem.
Stack trace before:
stack trace now: