Skip to content

Refactoring deployers into providers#5

Merged
BSick7 merged 1 commit intomasterfrom
app-pattern
Apr 17, 2021
Merged

Refactoring deployers into providers#5
BSick7 merged 1 commit intomasterfrom
app-pattern

Conversation

@BSick7
Copy link
Copy Markdown
Contributor

@BSick7 BSick7 commented Apr 16, 2021

This PR refactors the deployer pattern into a Provider pattern instead.
This has 2 major effects:

  1. The Provider pattern is a much simpler contract
  2. Instead of a Provider having a Detect, the providers are categorized by module category and type.
    The directory structure for these providers matches this categorization:
app
├── container
│   └── aws-fargate
├── server
├── serverless
│   └── aws-lambda
└── static-site
    └── aws-s3
...

@BSick7 BSick7 requested a review from ssickles April 16, 2021 11:19
Copy link
Copy Markdown
Member

@ssickles ssickles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all looks great to me. I like a lot of the renaming as well, makes it more clear.

@BSick7 BSick7 merged commit f0cdb22 into master Apr 17, 2021
@BSick7 BSick7 deleted the app-pattern branch April 17, 2021 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants