Fix compressor issues and address review feedback#397
Merged
Conversation
Agent-Logs-Url: https://github.com/XChikuX/react-native-compressor/sessions/98e6d175-52db-4405-a832-fb651d0255ee Co-authored-by: XChikuX <5894493+XChikuX@users.noreply.github.com>
Agent-Logs-Url: https://github.com/XChikuX/react-native-compressor/sessions/98e6d175-52db-4405-a832-fb651d0255ee Co-authored-by: XChikuX <5894493+XChikuX@users.noreply.github.com>
Agent-Logs-Url: https://github.com/XChikuX/react-native-compressor/sessions/98e6d175-52db-4405-a832-fb651d0255ee Co-authored-by: XChikuX <5894493+XChikuX@users.noreply.github.com>
Agent-Logs-Url: https://github.com/XChikuX/react-native-compressor/sessions/98e6d175-52db-4405-a832-fb651d0255ee Co-authored-by: XChikuX <5894493+XChikuX@users.noreply.github.com>
Agent-Logs-Url: https://github.com/XChikuX/react-native-compressor/sessions/98e6d175-52db-4405-a832-fb651d0255ee Co-authored-by: XChikuX <5894493+XChikuX@users.noreply.github.com>
Agent-Logs-Url: https://github.com/XChikuX/react-native-compressor/sessions/98e6d175-52db-4405-a832-fb651d0255ee Co-authored-by: XChikuX <5894493+XChikuX@users.noreply.github.com>
Agent-Logs-Url: https://github.com/XChikuX/react-native-compressor/sessions/98e6d175-52db-4405-a832-fb651d0255ee Co-authored-by: XChikuX <5894493+XChikuX@users.noreply.github.com>
numandev1
approved these changes
May 8, 2026
Owner
|
release it in v1.18.2 |
Contributor
Author
|
@numandev1 Hope you checked features and compile issues before merging.. |
Owner
|
@XChikuX I did not check it manually |
Contributor
Author
|
@numandev1 If you really want to be hands off with the updates. You need to add several tests. Otherwise, please verify these once manually. I am short on time to perform comprehensive testing from my end. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses the remaining real issues tracked in
TRIAGE.mdacross upload, thumbnailing, image quality, and Android video container handling.iOS background upload
URLSessionresponse data.bodyas a UTF-8 string, matching Android behavior.Thumbnail generation
Image quality
Android video output
mp4parseror produce invalid containers.Please treat as reference implementation. I've reviewed the changes though and they seem minimally invasive.
Should give fixes to long standing issues in this repo.