Skip to content

Conversation

@yhl25
Copy link
Contributor

@yhl25 yhl25 commented Mar 19, 2025

fixes #171

yhl25 added 3 commits March 19, 2025 21:45
Signed-off-by: Yashash H L <yashashhl25@gmail.com>
Signed-off-by: Yashash H L <yashashhl25@gmail.com>
@codecov
Copy link

codecov bot commented Mar 19, 2025

Codecov Report

Attention: Patch coverage is 78.16092% with 57 lines in your changes missing coverage. Please review.

Please upload report for BASE (main@cf0c12f). Learn more about missing BASE report.

Files with missing lines Patch % Lines
...maflow/accumulator/AccumulatorSupervisorActor.java 78.12% 13 Missing and 1 partial ⚠️
...java/io/numaproj/numaflow/accumulator/Service.java 68.18% 12 Missing and 2 partials ⚠️
.../java/io/numaproj/numaflow/accumulator/Server.java 60.60% 11 Missing and 2 partials ⚠️
...o/numaproj/numaflow/accumulator/ShutdownActor.java 52.38% 10 Missing ⚠️
.../io/numaproj/numaflow/accumulator/OutputActor.java 80.00% 2 Missing ⚠️
...numaflow/accumulator/OutputStreamObserverImpl.java 94.87% 0 Missing and 2 partials ⚠️
...va/io/numaproj/numaflow/accumulator/Constants.java 0.00% 1 Missing ⚠️
...a/io/numaproj/numaflow/accumulator/GRPCConfig.java 80.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #172   +/-   ##
=======================================
  Coverage        ?   59.93%           
  Complexity      ?      461           
=======================================
  Files           ?      150           
  Lines           ?     3312           
  Branches        ?      200           
=======================================
  Hits            ?     1985           
  Misses          ?     1194           
  Partials        ?      133           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

yhl25 added 2 commits March 20, 2025 19:32
Signed-off-by: Yashash H L <yashashhl25@gmail.com>
Signed-off-by: Yashash H L <yashashhl25@gmail.com>
@yhl25 yhl25 marked this pull request as ready for review March 20, 2025 16:08
@yhl25 yhl25 requested review from KeranYang and vigith March 20, 2025 16:08
yhl25 and others added 2 commits March 20, 2025 21:54
Signed-off-by: Yashash H L <yashashhl25@gmail.com>
Signed-off-by: Keran Yang <yangkr920208@gmail.com>
Copy link
Member

@KeranYang KeranYang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@KeranYang KeranYang merged commit 5030d44 into main Mar 21, 2025
3 checks passed
@KeranYang KeranYang deleted the accumulator branch March 21, 2025 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Accumulator in Java SDK

3 participants