Conversation
Signed-off-by: Sreekanth <prsreekanth920@gmail.com>
Signed-off-by: Sreekanth <prsreekanth920@gmail.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #213 +/- ##
=======================================
Coverage ? 60.79%
Complexity ? 561
=======================================
Files ? 155
Lines ? 3584
Branches ? 254
=======================================
Hits ? 2179
Misses ? 1225
Partials ? 180 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@BulkBeing Thanks for doing this. Why don't we create a |
I've seen some repos that provide kotlin apis with core implemented in Java having both files in same repo. In our case, I think separate repo makes sense, since we need to manage different versions (at-least initially) as Kotlin codebase will change more. Also, we need replicate all examples as well. |
|
Let's work towards the target state. If the target state is single repo, let's just stick to single repo. How will the artifact be published? Independently (Java and Kotlin together) or together? |
|
nm.. I see that the artifact is separate. |
Provide idiomatic Kotlin APIs around existing Java SDK.
SinkerAPIs and publishing the package.A sink implementation in kotlin using this sdk would look like:
The same would look like this if the user uses existing Java sdk in kotlin:
NOTE: My only experience with Kotlin is reading the book "Kotlin in Action, Second Edition". So I'm expecting the sdk APIs may change a lot as I gain more experience using Kotlin and getting feedback from Kotlin devs.