Skip to content

Conversation

@BulkBeing
Copy link
Contributor

@BulkBeing BulkBeing commented Sep 29, 2025

  • Excludes protobuf generated files from formatting using black
  • Changes from make proto

Looks like the main change in proto generated files is this version check:

GRPC_GENERATED_VERSION = '1.75.0'
GRPC_VERSION = grpc.__version__
_version_not_supported = False

try:
    from grpc._utilities import first_version_is_lower
    _version_not_supported = first_version_is_lower(GRPC_VERSION, GRPC_GENERATED_VERSION)
except ImportError:
    _version_not_supported = True

if _version_not_supported:
    raise RuntimeError(
        f'The grpc package installed is at version {GRPC_VERSION},'
        + f' but the generated code in map_pb2_grpc.py depends on'
        + f' grpcio>={GRPC_GENERATED_VERSION}.'
        + f' Please upgrade your grpc module to grpcio>={GRPC_GENERATED_VERSION}'
        + f' or downgrade your generated code using grpcio-tools<={GRPC_VERSION}.'
    )

Rest of the changes are due to previously formatting the generated code with black.

Signed-off-by: Sreekanth <prsreekanth920@gmail.com>
@codecov
Copy link

codecov bot commented Sep 29, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.62%. Comparing base (ac2b513) to head (1f7c447).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #250   +/-   ##
=======================================
  Coverage   93.62%   93.62%           
=======================================
  Files          65       65           
  Lines        2888     2888           
  Branches      152      152           
=======================================
  Hits         2704     2704           
  Misses        134      134           
  Partials       50       50           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@BulkBeing BulkBeing marked this pull request as ready for review September 30, 2025 00:06
@vigith vigith requested a review from kohlisid September 30, 2025 00:09
@vigith vigith merged commit 1ecb5c7 into main Sep 30, 2025
12 checks passed
@vigith vigith deleted the protobuf-codegen branch September 30, 2025 04:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants