Skip to content

Conversation

@BulkBeing
Copy link
Contributor

No description provided.

Signed-off-by: Sreekanth <prsreekanth920@gmail.com>
Signed-off-by: Sreekanth <prsreekanth920@gmail.com>
Signed-off-by: Sreekanth <prsreekanth920@gmail.com>
Signed-off-by: Sreekanth <prsreekanth920@gmail.com>
Signed-off-by: Sreekanth <prsreekanth920@gmail.com>
Signed-off-by: Sreekanth <prsreekanth920@gmail.com>
@codecov
Copy link

codecov bot commented Sep 28, 2025

Codecov Report

❌ Patch coverage is 80.00000% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 93.53%. Comparing base (ac2b513) to head (bb27dc8).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
pynumaflow/sourcer/servicer/async_servicer.py 75.00% 3 Missing ⚠️
pynumaflow/sourcer/_dtypes.py 84.61% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #249      +/-   ##
==========================================
- Coverage   93.62%   93.53%   -0.10%     
==========================================
  Files          65       65              
  Lines        2888     2909      +21     
  Branches      152      152              
==========================================
+ Hits         2704     2721      +17     
- Misses        134      138       +4     
  Partials       50       50              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Signed-off-by: Sreekanth <prsreekanth920@gmail.com>
@vigith
Copy link
Member

vigith commented Sep 28, 2025

lot of files have been changed since the gRPC version changed, can you try to avoid that?

Signed-off-by: Sreekanth <prsreekanth920@gmail.com>
Signed-off-by: Sreekanth <prsreekanth920@gmail.com>
@BulkBeing
Copy link
Contributor Author

lot of files have been changed since the gRPC version changed, can you try to avoid that?

I only ran make proto. We are using protobuf version 6.32.1. The generated code in the main shows:

# Protobuf Python Version: 4.25.1

The 4.x version is already end of support https://protobuf.dev/support/version-support/#python
It looks like we were not committing generated code to Github.

… tests

Signed-off-by: Sreekanth <prsreekanth920@gmail.com>
@BulkBeing
Copy link
Contributor Author

Created smaller PRs #250 and #252

@BulkBeing BulkBeing closed this Sep 30, 2025
@BulkBeing BulkBeing deleted the source-nack branch September 30, 2025 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants