-
Couldn't load subscription status.
- Fork 24
feat: Nack support for Sources #252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Sreekanth <prsreekanth920@gmail.com>
Signed-off-by: Sreekanth <prsreekanth920@gmail.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #252 +/- ##
==========================================
+ Coverage 93.66% 93.70% +0.04%
==========================================
Files 65 65
Lines 2888 2907 +19
Branches 152 152
==========================================
+ Hits 2705 2724 +19
Misses 133 133
Partials 50 50 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Sreekanth <prsreekanth920@gmail.com>
Signed-off-by: Sreekanth <prsreekanth920@gmail.com>
Signed-off-by: Sreekanth <prsreekanth920@gmail.com>
Signed-off-by: Sreekanth <prsreekanth920@gmail.com>
pynumaflow/sourcer/async_server.py
Outdated
| ReadRequest, | ||
| Message, | ||
| AckRequest, | ||
| NacRequest, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: typo
Closes #248
Implementation of numaproj/numaflow#2923
Tested by running pipeline locally.