Skip to content

Conversation

@BulkBeing
Copy link
Contributor

@BulkBeing BulkBeing commented Sep 30, 2025

Closes #248

Implementation of numaproj/numaflow#2923

Tested by running pipeline locally.

Signed-off-by: Sreekanth <prsreekanth920@gmail.com>
Signed-off-by: Sreekanth <prsreekanth920@gmail.com>
@codecov
Copy link

codecov bot commented Sep 30, 2025

Codecov Report

❌ Patch coverage is 92.00000% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 93.70%. Comparing base (1ecb5c7) to head (a8c7951).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
pynumaflow/sourcer/_dtypes.py 86.66% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #252      +/-   ##
==========================================
+ Coverage   93.66%   93.70%   +0.04%     
==========================================
  Files          65       65              
  Lines        2888     2907      +19     
  Branches      152      152              
==========================================
+ Hits         2705     2724      +19     
  Misses        133      133              
  Partials       50       50              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Signed-off-by: Sreekanth <prsreekanth920@gmail.com>
Signed-off-by: Sreekanth <prsreekanth920@gmail.com>
Signed-off-by: Sreekanth <prsreekanth920@gmail.com>
Signed-off-by: Sreekanth <prsreekanth920@gmail.com>
@BulkBeing BulkBeing requested a review from kohlisid September 30, 2025 12:51
@BulkBeing BulkBeing marked this pull request as ready for review September 30, 2025 12:51
@vigith vigith linked an issue Sep 30, 2025 that may be closed by this pull request
ReadRequest,
Message,
AckRequest,
NacRequest,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: typo

Signed-off-by: Sreekanth <prsreekanth920@gmail.com>
@BulkBeing BulkBeing merged commit 5f2c89a into main Oct 1, 2025
12 checks passed
@BulkBeing BulkBeing deleted the source-nack-support branch October 1, 2025 00:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Nack Support For User Defined Source

3 participants