chore: Update to Cython3 #96
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As hoped, this upgrade significantly simplifies the install-requirements.sh script. Provides additional progress on numberscope#43. Note this must be tested with care (additional details in PR). Resolves numberscope#82.
katestange
approved these changes
Oct 23, 2023
Member
katestange
left a comment
katestange
left a comment
There was a problem hiding this comment.
No comments on the code. I checkout out this PR, blew away my virtual environment, recreated it, blew away my database, recreated it, ran the backscope, and then ran tests, all successfully.
Member
|
Let me know if you are ok with me merging. I think I did the checks needed. |
Collaborator
Author
|
Great news, merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As hoped, this upgrade significantly simplifies the install-requirements.sh
script. Provides additional progress on #43.
Note this must be tested with care (additional details in PR).
Resolves #82.
NOTE the additional testing details: To properly test this PR, you must blow away your entire .venv virtual environment, and reset your database. Then re-do the installation from the step of creating the virtual environment. When
flask runsucceeds and you have successfully hit the resulting server getting back sensible data, then you can runflask test. When all of that is good, and if the source changes look OK under review, then this PR can be approved to merge.