Fix XSS vulnerabilities in Wix integration examples#98
Merged
Conversation
…prevent XSS Co-authored-by: numbers-official <181934381+numbers-official@users.noreply.github.com> Agent-Logs-Url: https://github.com/numbersprotocol/capture-eye/sessions/e9264c31-bfa3-4ca2-8702-beb989460f28
Copilot
AI
changed the title
[WIP] Fix XSS vulnerabilities in Wix integration examples
Fix XSS vulnerabilities in Wix integration examples
Mar 25, 2026
added 4 commits
April 16, 2026 05:26
… nid link - Clear existing children in capture-eye-element.js connectedCallback before appending, matching the original innerHTML replacement behavior - Add cursor:pointer to nidP so users know it is clickable
- Replace while/removeChild loop with replaceChildren() for clarity - Add 'noopener' to window.open to prevent opener access from new tab
- Rename capture-eye-sytle-element.js → capture-eye-style-element.js - Add 'N/A' fallback for headline, consistent with creator
The original code had no fallback for headline. Adding '|| N/A' would change the displayed value when the attribute is missing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Wix example custom elements used
innerHTMLwith unsanitized attribute values interpolated via template literals, allowing arbitrary HTML/JS injection. The inlineonclickincapture-eye-sytle-element.jsalso constructed a URL directly from a raw attribute value.Changes
examples/wix/capture-eye-element.jsinnerHTMLtemplate literal withcreateElement+setAttributefor bothcapture-eyeandmedia-viewerexamples/wix/capture-eye-sytle-element.jsinnerHTMLblock with explicit DOM construction; all text set viatextContentonclick="window.open('.../${_nid}'...)"withaddEventListener('click', ...)usingencodeURIComponent(_nid)removeChildloop instead ofinnerHTML = ''Before:
After:
Original prompt
⌨️ Start Copilot coding agent tasks without leaving your editor — available in VS Code, Visual Studio, JetBrains IDEs and Eclipse.