Skip to content

Incremented version of the gradle shadow plugin to 1.2.3#391

Merged
cogmission merged 1 commit intonumenta:masterfrom
erinloy:master
Feb 22, 2016
Merged

Incremented version of the gradle shadow plugin to 1.2.3#391
cogmission merged 1 commit intonumenta:masterfrom
erinloy:master

Conversation

@erinloy
Copy link
Copy Markdown
Contributor

@erinloy erinloy commented Feb 21, 2016

Fixes #392
Incremented version of the gradle shadow plugin to 1.2.3, which contains a fix for compatibility with gradle 2.11 and higher.

…ins a fix for compatibility with gradle 2.11 and higher
@cogmission
Copy link
Copy Markdown
Collaborator

Hi Erin, Thank you and Welcome!

Sorry, I've been sick the past few days and haven't been monitoring things. I think all that's left is to make sure my method of pushing to the Maven repository still works - and that you have signed Numenta's Contributor's License here. I see you already figured out the "Fixes Issue" validator requirement of putting "Fixes #nnn" in your comment...

Cheers,
David

@erinloy
Copy link
Copy Markdown
Contributor Author

erinloy commented Feb 22, 2016

Just received word that the license has been processed.

Erin
On Feb 21, 2016 12:50 AM, "David Ray" notifications@github.com wrote:

Hi Erin, Thank you and Welcome!

Sorry, I've been sick the past few days and haven't been monitoring
things. I think all that's left is to make sure my method of pushing to the
Maven repository still works - and that you have signed Numenta's Contributor's
License here http://numenta.org/licenses/cl/. I see you already figured
out the "Fixes Issue" validator requirement of putting "Fixes #nnn" in your
comment...

Cheers,
David


Reply to this email directly or view it on GitHub
#391 (comment).

@rhyolight
Copy link
Copy Markdown
Member

👍

@cogmission
Copy link
Copy Markdown
Collaborator

@rhyolight, I still don't see @erinloy in the "Assignee" drop down list?

@rhyolight
Copy link
Copy Markdown
Member

That is because he has not accepted the invitation from us to join the
"nupic-contrib" Github Team.


Matt Taylor
OS Community Flag-Bearer
Numenta

On Mon, Feb 22, 2016 at 8:53 AM, David Ray notifications@github.com wrote:

@rhyolight https://github.com/rhyolight, I still don't see @erinloy
https://github.com/erinloy in the "Assignee" drop down list?


Reply to this email directly or view it on GitHub
#391 (comment).

@cogmission
Copy link
Copy Markdown
Collaborator

Is that required?

@rhyolight
Copy link
Copy Markdown
Member

No, but if he doesn't accept, he cannot be associated with any Github
issues.


Matt Taylor
OS Community Flag-Bearer
Numenta

On Mon, Feb 22, 2016 at 9:02 AM, David Ray notifications@github.com wrote:

Is that required?


Reply to this email directly or view it on GitHub
#391 (comment).

@cogmission
Copy link
Copy Markdown
Collaborator

Sounds like a "yes" to me? :-P

@rhyolight
Copy link
Copy Markdown
Member

Well, you can merge the PR as far as I'm concerned.


Matt Taylor
OS Community Flag-Bearer
Numenta

On Mon, Feb 22, 2016 at 9:06 AM, David Ray notifications@github.com wrote:

Sounds like a "yes" to me? :-P


Reply to this email directly or view it on GitHub
#391 (comment).

@cogmission
Copy link
Copy Markdown
Collaborator

@rhyolight Ok, sounds good...

cogmission added a commit that referenced this pull request Feb 22, 2016
Incremented version of the gradle shadow plugin to 1.2.3
@cogmission cogmission merged commit 916da34 into numenta:master Feb 22, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Gradle error: Could not create task of type 'ShadowJar'

3 participants