Skip to content

Added Locale.US to MetricsTrace.java#396

Merged
cogmission merged 2 commits intonumenta:masterfrom
Setus:MyBranch
Feb 25, 2016
Merged

Added Locale.US to MetricsTrace.java#396
cogmission merged 2 commits intonumenta:masterfrom
Setus:MyBranch

Conversation

@Setus
Copy link
Copy Markdown
Contributor

@Setus Setus commented Feb 25, 2016

Fixes #394
Added Locale.US to ensure that the tests were executed using dot decimal punctuation only.

Added Locale.US to ensure that the tests were executed using dot decimal punctuation instead of whatever the local JVM decided to use.
@Setus
Copy link
Copy Markdown
Contributor Author

Setus commented Feb 25, 2016

Seems like I still haven't got my CL approved.
Travis seems to be perpetually building, or not at all since I get the message "Hang tight, the log cannot be shown until the build has started." when I clik on Details.

@Setus
Copy link
Copy Markdown
Contributor Author

Setus commented Feb 25, 2016

Woohoo! Travis managed to build successfully, just the CL approval remaining then.

@rhyolight
Copy link
Copy Markdown
Member

@Setus We processed the license... something is wrong with the validator. I think it is just a case-sensitivity issue. @cogmission you are good to merge despite the failing "Contributor Validator". I'm working on that.

@rhyolight
Copy link
Copy Markdown
Member

Ok I guess I fixed it. ;)

cogmission added a commit that referenced this pull request Feb 25, 2016
Added Locale.US to MetricsTrace.java
@cogmission cogmission merged commit 6064703 into numenta:master Feb 25, 2016
@cogmission
Copy link
Copy Markdown
Collaborator

Good work @Setus and @rhyolight ! @Setus usually changes go through much much faster - I've been down with a fever...

@Setus
Copy link
Copy Markdown
Contributor Author

Setus commented Feb 26, 2016

@cogmission Don't sweat it, it's been a fun learning experience, and thanks for putting up with me 😄

@Setus Setus deleted the MyBranch branch February 26, 2016 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants