Skip to content

#405 - reference build environment w/ docker#402

Merged
cogmission merged 7 commits intonumenta:masterfrom
EronWright:Dockerfile
Mar 27, 2016
Merged

#405 - reference build environment w/ docker#402
cogmission merged 7 commits intonumenta:masterfrom
EronWright:Dockerfile

Conversation

@EronWright
Copy link
Copy Markdown
Contributor

Defines a 'reference' build environment that should 'always work'. Based on the official OpenJDK8 docker image (Debian-based) plus Gradle 2.12.

Closes #405.

@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage remained the same at 80.694% when pulling bd71e59 on EronWright:Dockerfile into 84f998c on numenta:master.

@cogmission
Copy link
Copy Markdown
Collaborator

Hi Eron,

This looks exciting! Before we get started, the reason why you have "unsuccessful checks" is because you need to put "Fixes #nnn" in your first line of the first comment in this PR (It's a Numenta policy that all PRs address specific Issues) - and you need to create an "Issue" that explains what the "need" is, then reference it here in this PR as described above,

See these for an example of what I'm talking about: #399 , #400 see the comment in the last one.

👍

@cogmission
Copy link
Copy Markdown
Collaborator

Secondly, I wanted to ask if you could extend the wiki (add to the side bar on the right too)?

The side bar could be Docker File Setup, or Docker: Universal Working Reference Build Env or something probably shorter than that last suggestion :-P

...and then create that wiki page explaining how to use your new environment? Or you can write the wiki text and I can put it in to the repos wiki structure if you like? I will help if needed?

Cheers, and great work!,

David

@cogmission
Copy link
Copy Markdown
Collaborator

@EronWright Also, the Docker version should use the Oracle JDK - I don't have the time to debug different JDKs... (Unless someone else wants to work on that?)

Also, I didn't see that the build wasn't working inside the Docker environment - this has to be solved before this PR is accepted.

@cogmission
Copy link
Copy Markdown
Collaborator

@EronWright I solved the Linux issue, its Gradle once again... You have to make sure that Gradle is pointing to the right version of Java...

@EronWright
Copy link
Copy Markdown
Contributor Author

This weekend:

  1. I'll move the README content to the wiki as you suggest.
  2. I'll take a look at the test issues that are breaking the build under OpenJDK.
  3. I'll file an issue.

@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage remained the same at 80.694% when pulling 2a42fb2 on EronWright:Dockerfile into 84f998c on numenta:master.

@cogmission
Copy link
Copy Markdown
Collaborator

@EronWright Awesomeness! Thank you... 👍

@cogmission
Copy link
Copy Markdown
Collaborator

@EronWright I didn't see the README.md changes... I think you should leave the section entitled:

Reference Build Environment
Follow the instructions [here](http://github.com... some wiki url) to create a Docker image containing an HTM.java build environment.

Note: This is only necessary if you want to run HTM.java inside Docker. If you want a "normal" build environment, then you can skip the instructions posted at the above wiki link.

...and then copy everything else to the wiki as we discussed.

Nice verbiage by the way! I didn't see it... I like it! :-)

@cogmission
Copy link
Copy Markdown
Collaborator

@EronWright Please look at my last Gitter comment, the versions while the same don't cause the issue. Gradle must point to exactly the same JDK installation. (at least that's what I have seen over and over again now, the latest being with @addos)

@EronWright EronWright changed the title reference build environment w/ docker #405 - reference build environment w/ docker Mar 26, 2016
@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage remained the same at 80.694% when pulling 34aff22 on EronWright:Dockerfile into 43abaf6 on numenta:master.

@EronWright
Copy link
Copy Markdown
Contributor Author

@cogmission please review. All tests pass with Gradle and with Maven. Please consider #406 as a prerequisite.

Note that I moved some of the build instructions to a dedicated wiki page.

@cogmission
Copy link
Copy Markdown
Collaborator

Great! Thank you @EronWright 👍

I didn't see the " **PA**LayerTest in the error output so I thought my fix didn't work :-( " I thought the error was with "LayerTest" still, because it was the same three internal tests. Thank you for catching that! I should have added the fix to that test class too...

@cogmission cogmission closed this Mar 27, 2016
@cogmission cogmission reopened this Mar 27, 2016
@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage remained the same at 80.694% when pulling 5ade44e on EronWright:Dockerfile into 43abaf6 on numenta:master.

@cogmission cogmission merged commit ec1c9fb into numenta:master Mar 27, 2016
@EronWright EronWright deleted the Dockerfile branch March 27, 2016 02:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants