#405 - reference build environment w/ docker#402
Conversation
|
Hi Eron, This looks exciting! Before we get started, the reason why you have "unsuccessful checks" is because you need to put "Fixes #nnn" in your first line of the first comment in this PR (It's a Numenta policy that all PRs address specific Issues) - and you need to create an "Issue" that explains what the "need" is, then reference it here in this PR as described above, See these for an example of what I'm talking about: #399 , #400 see the comment in the last one. 👍 |
|
Secondly, I wanted to ask if you could extend the wiki (add to the side bar on the right too)? The side bar could be Docker File Setup, or Docker: Universal Working Reference Build Env or something probably shorter than that last suggestion :-P ...and then create that wiki page explaining how to use your new environment? Or you can write the wiki text and I can put it in to the repos wiki structure if you like? I will help if needed? Cheers, and great work!, David |
|
@EronWright Also, the Docker version should use the Oracle JDK - I don't have the time to debug different JDKs... (Unless someone else wants to work on that?) Also, I didn't see that the build wasn't working inside the Docker environment - this has to be solved before this PR is accepted. |
|
@EronWright I solved the Linux issue, its Gradle once again... You have to make sure that Gradle is pointing to the right version of Java... |
|
This weekend:
|
|
@EronWright Awesomeness! Thank you... 👍 |
|
@EronWright I didn't see the README.md changes... I think you should leave the section entitled:
...and then copy everything else to the wiki as we discussed. Nice verbiage by the way! I didn't see it... I like it! :-) |
|
@EronWright Please look at my last Gitter comment, the versions while the same don't cause the issue. Gradle must point to exactly the same JDK installation. (at least that's what I have seen over and over again now, the latest being with @addos) |
- added Maven - enabled Gradle daemon
|
@cogmission please review. All tests pass with Gradle and with Maven. Please consider #406 as a prerequisite. Note that I moved some of the build instructions to a dedicated wiki page. |
|
Great! Thank you @EronWright 👍 I didn't see the " **PA**LayerTest in the error output so I thought my fix didn't work :-( " I thought the error was with "LayerTest" still, because it was the same three internal tests. Thank you for catching that! I should have added the fix to that test class too... |
Defines a 'reference' build environment that should 'always work'. Based on the official OpenJDK8 docker image (Debian-based) plus Gradle 2.12.
Closes #405.