Skip to content

Junit observer fix#435

Merged
rhyolight merged 9 commits intonumenta:masterfrom
cogmission:junit_observer_fix
Jul 18, 2016
Merged

Junit observer fix#435
rhyolight merged 9 commits intonumenta:masterfrom
cogmission:junit_observer_fix

Conversation

@cogmission
Copy link
Copy Markdown
Collaborator

fixes #434

  • Added TestObserver solution found by @fergalbyrne
  • Inserted TestObserver in all relevant tests
  • Created new test base class to handle new test remedy

@rhyolight please approve

@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage increased (+0.04%) to 81.124% when pulling 9ef5252 on cogmission:junit_observer_fix into 227feb0 on numenta:master.

@rhyolight
Copy link
Copy Markdown
Member

Wow, you've got tests for your tests!

@rhyolight rhyolight merged commit 1d58c62 into numenta:master Jul 18, 2016
@cogmission
Copy link
Copy Markdown
Collaborator Author

@rhyolight That's funny... :-)

But it really shows the vulnerability of putting assertions in Observers under certain circumstances, and clearly demonstrates the potential problem within HTM.Java's NAPI if it's not handled correctly. So it mostly acts as a way to document the "preferred" testing idiom.

@cogmission cogmission deleted the junit_observer_fix branch July 23, 2016 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

JUnit tests not reporting errors for assertions in onNext()

3 participants