Fix dark mode font color for version switcher#40
Merged
mattip merged 1 commit intonumpy:mainfrom Apr 9, 2026
Merged
Conversation
Member
|
Should we fix the other 2.* docs which also suffer from this problem? |
Member
|
Are you sure this fixed the problem? I still see black on black, but maybe some thing is caching somewhere. |
Member
Author
|
It did work for me! Sure, I can go and fix the older docs as well, it's a simple fix. |
Member
|
Correct, I checked too soon, some caching must have taken time to propagate.
Thanks, that would be helpful |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See numpy/numpy#31028 - this fixes the version switcher button font for dark mode in the 2.4 version.
The other items in that PR I don't think need fixing but this item is illegible which has impacts to accessibility and readability.