-
-
Notifications
You must be signed in to change notification settings - Fork 13
FEAT: Extending QuadPrecision input to support arrays, sequences and np.numbers
#199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, just a few minor comments.
|
@ngoldbaum suggestions applied |
|
I realized after we merged this that this doesn't update the type stubs. Ping @jorenham. Not sure if there's any testing we can do to ensure the tests themselves don't do things that violate the type stubs? |
Stubtest is able to detect any api changes that are visible by using the TLDR; theoretically yes, practically no 🤷🏻 |
closes #198