ENH: inherit numerical dtypes from abstract ones. #26171
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 3ac9316.
Ensure that they only promote integers. Also adds back the regression test.
This ensures comparisons for unequal integer dtype do not return object.
Otherwise, the API table is too short!
charris
added
00 - Bug
01 - Enhancement
08 - Backport
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #26116.
I couldn't quite stand how we are working around not having abstract dtypes by adding weird promotors in #26105, so thought one should just make them, especially since (as I found out) all the basic infrastructure is there.
So, this let's all numerical legacy dtypes inherit from the abstract types defined for python
int,floatandcomplex. This follows what was mentioned to be the plan all along in the comments inabstractdtype, though it does not yet change the names throughout, since I wanted to be sure first I'm not barking up the wrong tree (it took the better part of the day already, mostly to realize that the abstract dtypes better inherit fromPyArrayDescr_Type, otherwise nothing works).Anyway, with this, the
StringDTypemultiplication promotors are now their logical selves, the work-around can be removed, and everything works.