-
-
Notifications
You must be signed in to change notification settings - Fork 11.7k
[WIP] DOC: remove numpy.distutils references from f2py docs #26490
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This is an installment in addressing ticket numpy#25597, tackling only the f2py documentation. This is a draft only. I will need some feedback on my edits before this change is ready for CI. [skip ci] [skip actions] [skip azp] [skip cirrus]
Not sure since I have never seen this before. Your commit message may be related, it contains: all those are individually correct, but If you want only the docs to build on CircleCI, use: |
the redundant skip-CI tag from my original commit will fix the Azure pipeline failures my pull request is experiencing. Here's the belt without the suspenders: [skip actions] [skip azp] [skip cirrus]# Please enter the commit message for your changes. Lines starting
|
@rgommers You nailed it in one. Thank you. |
|
In looking for additional references to distutils, I find that I missed:
It would seem to make sense for those files to be cleaned up in this PR. Unfortunately, I'm traveling most days from now till 13 June. If I get feedback from @HaoZeke on the changes listed in my Context section above, I'll get back to work on this in mid-June and do my best to incorporate these missed files. If, instead, getting distutils references cleaned up becomes a priority for someone else, I'd be happy to have them incorporate some or all of my changes into another PR and this one be closed/abandoned. |
| .. note:: | ||
|
|
||
| The current default build system for ``f2py`` is ``meson``. | ||
| If you need information about the migration from ``numpy.distutils`` to | ||
| ``meson``, refer to this section in the Version 1.26 documentation. | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should have a link here to the document in question. Also, possibly in scope for this PR is that we still have distutils as the default if the Python version is less than 3.12 (see f2py2e.py around 556).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In fact, perhaps until 3.12 becomes the lowest supported version we should keep distutils-to-meson.rst since (most) F2PY users probably haven't transitioned.
|
Hi @eagunn, I took a quick look, and raised some discussion points, other than that the changes look good, hope travel is going well! |
|
@eagunn is this still active? |
|
@mattip, Thanks for asking. I haven't abandoned it. However, while I was waiting for input I decided to tackle a less complicated set of changes so I could get through the commit/PR/merge cycle a couple of times. (And, I just had my very first PR merged. Huzzah!) I hope to get back to this PR next week, take on board the comments above, and then simplify/finalize it. |
|
I'm closing this PR. It was a poor choice for a first-issue for me to work on. There are some issues of technical substance and of timing that I still do not understand. I'm preserving the branch in my own repo and @HaoZeke's helpful comments in case I want to work on it again later. For now, though, it is cruft in this repo that we don't need to have lying around. |
This is an installment in addressing ticket #25597, tackling only the f2py documentation.
This is a draft only. I will need some feedback on my edits before this change is ready for CI. @HaoZeke, when you have time could you review, using my list below to point out changes that may surprise or displease you.
[skip actions] [skip azp] [skip cirrus]
Context
This change is not as simple or local as I originally expected.