Skip to content

Conversation

@mdhaber
Copy link
Contributor

@mdhaber mdhaber commented Nov 11, 2024

gh-24978 deprecated the use of keywords x and y in numpy.testing.assert_array_equal and numpy.testing.assert_array_almost_equal.

This PR removes the decorator that warned about the deprecation and allowed continued use of x and y; after the PR, only actual and desired are accepted.

@seberg
Copy link
Member

seberg commented Nov 12, 2024

Not that I think this is a big enough deprecation to worry, so happy if someone reviews+merges.

But on principle we should probably consider 2.0 and 2.1 a single release for deprecation purposes, in order to stay with the ~1 year of deprecation.

@mdhaber
Copy link
Contributor Author

mdhaber commented Nov 12, 2024

Oops, yeah. I forgot that 2.0 didn't come out until June. I'm happy to wait until 2.3; I had just set a reminder for one year because i didn't want to forget.

@seberg seberg modified the milestones: 2.2.0 release, 2.3.0 release Nov 15, 2024
@charris charris merged commit 2ff895d into numpy:main Nov 28, 2024
70 checks passed
@charris
Copy link
Member

charris commented Nov 28, 2024

Thanks @mdhaber .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants