CI: add windows free-threaded CI #27819
Conversation
ngoldbaum
added
the
39 - free-threading
|
Darn looks like this breaks 32-bit 3.10 on windows. I'll try to fix that on Monday. |
rgommers
left a comment
rgommers
left a comment
There was a problem hiding this comment.
Thanks Nathan. Overall this looks good. I would prefer to not add two new jobs, that's a bit too heavyweight. Why not just switch one job over? E.g., use MSVC for 3.11 and Clang-cl for 3.13t. There shouldn't be much (if any) cross-talk between compilers and Python versions.
|
Last push adds |
This comment was marked as outdated.
This comment was marked as outdated.
|
@rgommers I think this is ready now. |
ngoldbaum
force-pushed
the
windows-nogil-ci
branch
from
a351955 to
cc8350a
Compare
rgommers
left a comment
rgommers
left a comment
There was a problem hiding this comment.
Looks quite good overall - a few small comments/questions.
| if sys.platform == 'win32': | ||
| compile_extra = ["/we4013"] | ||
| link_extra = ["/LIBPATH:" + os.path.join(sys.base_prefix, 'libs')] | ||
| link_extra.append('/DEBUG') # generate .pdb file |
There was a problem hiding this comment.
Not sure this will be robust, but I don't mind adding it if CI is happy
There was a problem hiding this comment.
This is just keeping the behavior we had before, there's another sys.platform == 'win32' block below I merged with this one.
I did delete the LIBPATH stuff because meson handles this now.
| and os.path.exists(s + 'include')): | ||
| include_dirs.append(s + 'include') | ||
| if s + 'lib' not in library_dirs and os.path.exists(s + 'lib'): | ||
| library_dirs.append(s + 'lib') |
There was a problem hiding this comment.
This mess can indeed go now I think.
rgommers
left a comment
rgommers
left a comment
There was a problem hiding this comment.
LGTM now, let's give this a go. Thanks Nathan!
3 participants
This enables CI for the free-threaded build on Windows. The CI config follows what I did for Linux and MacOS.
It adds two new CI jobs to our Github Actions config.
This also fixes a number of issues with the
extbuildhelper for testing C extensions, both on the free-threaded build and in general.While I was here, I fixed some questionable software engineering choices like using mutables as the default value for keyword arguments and an unnecessary try/except I found annoying for debugging.
It also fixes the way libpython is linked against on the free-threaded build. Meson's
link_argscan use unix-style-L/path -lname_of_librarysyntax on all platforms, so I used it here even if it looks weird in Windows-specific configuration.Also fixes issues caused by
python.hnot settingPy_GIL_DISABLEDon Windows, so we need to do that ourselves.