TYP: Fix signatures of linalg.matmul and linalg.outer
#29846
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorenham
added
09 - Backport-Candidate
jorenham
commented
Sep 30, 2025
| "vecdot", | ||
| ] | ||
|
|
||
| _ArrayT = TypeVar("_ArrayT", bound=NDArray[Any]) |
|
Thanks Joren. |
charris
pushed a commit
to charris/numpy
that referenced
this pull request
Oct 2, 2025
…29846) This fixes several issues in np.linalg.outer (positional-only params, a misplaced out=... param, and an orphanced -> _ArrayT), and also fixes linalg.matmul parameters to be positional-only. I also snuck in an an additional overload that improves the return type if both input array-likes have the same dtype.
charris
added a commit
to charris/numpy
that referenced
this pull request
Oct 2, 2025
Backports of numpy#29842, numpy#29845, numpy#29846, numpy#29847. commit fe3a74c Author: Joren Hammudoglu <jhammudoglu@gmail.com> Date: Wed Oct 1 03:56:24 2025 +0200 TYP: Fix incompatible defaults in ``polyfit``, ``histogram``, and ``histogramdd`` (numpy#29847) The default values weren't assignable to the types of the parameters. commit 2342cb0 Author: Joren Hammudoglu <jhammudoglu@gmail.com> Date: Wed Oct 1 03:54:37 2025 +0200 TYP: Fix signatures of ``linalg.matmul`` and ``linalg.outer`` (numpy#29846) This fixes several issues in np.linalg.outer (positional-only params, a misplaced out=... param, and an orphanced -> _ArrayT), and also fixes linalg.matmul parameters to be positional-only. I also snuck in an an additional overload that improves the return type if both input array-likes have the same dtype. commit a8d7d13 Author: Joren Hammudoglu <jhammudoglu@gmail.com> Date: Wed Oct 1 03:53:00 2025 +0200 TYP: Add missing ``rtol`` kwarg to ``linalg.pinv`` (numpy#29845) Apparently it was added in 2.0.0, but was missing from the stubs. commit d9f83ec Author: Joren Hammudoglu <jhammudoglu@gmail.com> Date: Wed Oct 1 03:47:57 2025 +0200 TYP: Fix ``generic.__new__`` return type (numpy#29842)
bwhitt7
pushed a commit
to bwhitt7/numpy
that referenced
this pull request
Oct 7, 2025
…29846) This fixes several issues in np.linalg.outer (positional-only params, a misplaced out=... param, and an orphanced -> _ArrayT), and also fixes linalg.matmul parameters to be positional-only. I also snuck in an an additional overload that improves the return type if both input array-likes have the same dtype.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes several issues in
np.linalg.outer(positional-only params, a misplacedout=...param, and an orphanced-> _ArrayT), and also fixeslinalg.matmulparameters to be positional-only.I also snuck in an an additional overload that improves the return type if both input array-likes have the same dtype.