Skip to content

Conversation

@rossbar
Copy link
Contributor

@rossbar rossbar commented Nov 14, 2025

Two minor updates to the CI:

  1. Add Python3.14 to the default (i.e. latest sphinx) testing matrix
  2. Add the --pre flag to the job named "prerelease"

I suspect number 2 was intended - regardless, it's definitely worthwhile to test against sphinx rc's in particular.

There are more extensive CI changes that I think are worthwhile - for example, the testing matrix for old sphinx versions include sphinx/Python combos for which there are no wheels (e.g. sphinx v6 only supplies wheels up to Python3.11, but we test with 3.12 and 3.13 there too). Such changes might warrant more discussion so I'll save them for a separate PR - the two changes should be uncontroversial.

- name: Install
run: |
python -m pip install . --group test --group doc
python -m pip install --pre . --group test --group doc
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this just to catch pre-releases on pypi, or would you prefer to pull from the Nightly Wheels? Either way is fine, changes look good :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The most important dependency to catch (IMO) is sphinx - that's really where numpydoc would benefit from dev-testing to ensure that sphinx changes don't break the extension. AFAIK there are no sphinx nightlies, so catching the RC's is as good as we can do for now!

@stefanv
Copy link
Contributor

stefanv commented Nov 14, 2025

There are more extensive CI changes that I think are worthwhile - for example, the testing matrix for old sphinx versions include sphinx/Python combos for which there are no wheels (e.g. sphinx v6 only supplies wheels up to Python3.11, but we test with 3.12 and 3.13 there too). Such changes might warrant more discussion so I'll save them for a separate PR - the two changes should be uncontroversial.

I don't think that's controversial, FWIW.

@stefanv stefanv merged commit eb831f4 into numpy:main Nov 14, 2025
28 checks passed
@stefanv
Copy link
Contributor

stefanv commented Nov 14, 2025

Thanks!

@rossbar rossbar mentioned this pull request Nov 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants