Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR ports several upstream NumPy typing improvements from the main NumPy repository, focusing on type annotation refinements and interface updates across multiple modules.
- Improves type safety by adding more specific type annotations and updating generic type variables
- Updates function signatures to accept
Nonevalues where appropriate in reduction functions - Refines type definitions for better compatibility with typing checkers
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/numpy-stubs/lib/_iotools.pyi | Updates type annotations, renames validation kwargs class, and adds new utility functions |
| src/numpy-stubs/_core/overrides.pyi | Refactors type variables and introduces type aliases for better dispatcher typing |
| src/numpy-stubs/_core/fromnumeric.pyi | Adds None support to all() and any() function signatures |
| src/numpy-stubs/_core/_multiarray_umath.pyi | Changes parameter types from Sequence to SupportsLenAndGetItem |
| src/numpy-stubs/init.pyi | Exports additional _NoValue symbol from _globals |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This ports the following upstream changes:
numpy._NoValuenumpy#29170_core.overridesnumpy#29171any(None)andall(None)numpy#29176lib._iotoolsannotation improvements numpy#29177ravel_multi_indexfalse rejections numpy#29184Closes #581