✅ Add type tests covering all relevant datetime64 and timedelta64#859
✅ Add type tests covering all relevant datetime64 and timedelta64#859jorenham merged 4 commits intonumpy:mainfrom
datetime64 and timedelta64#859Conversation
|
converting in draft, i'll fix these ci-failures. |
|
#95 just saw this, i guess this could be the reason for ci-failure for these tests as per my understanding we can add |
Fixing #95 is probably more difficult that you might think. You're of course welcome to try; but it can be pretty tricky to deal get all the type-checkers on the same page when dealing with |
thanks, i thought it would be simple, but as you mentioned its probably more difficult, i can give it try and reach out to you if i stuck or have any query, if that's fine .. |
jorenham
left a comment
There was a problem hiding this comment.
let's add a brief comment explaining why we need these type igores
sure 👍 |
datetime64 and timedelta64
|
thanks |
towards #417
tests includes :-
datetime + timedeltadatetime - timedeltadatetime - datetimetimedelta + timedeltatimedelta - timedeltatimedelta / timedeltatimedelta % timedeltaplease let me know if we need improvements in this or i've missed any test coverage .. ThankYou 😊