linkbinary,dag: pass module list via link manifest so lockfile-free builds emit dep lines#80
Merged
aldoborrero merged 1 commit intomainfrom Apr 10, 2026
Merged
Conversation
…uilds emit dep lines link-binary populated debug.BuildInfo.Deps only by reading the lockfile, so lockfile-free builds (goLock = null) embedded zero `dep` lines and `go version -m` showed only path/mod/build. The Nix build graph already has the resolved module set (allModules + replacements), so thread it as `modules` in the link manifest and consume that instead. Replacement targets are filtered so a fork-style replace records `dep <orig> => <repl>` rather than a spurious second dep entry. The lockfile-read fallback is removed: nix/dag is the only manifest producer and now always emits modules; the lockfile is still passed for mvscheck.CheckLockfile. Both wrapper tests now assert `go version -m` contains dep lines (testify-basic for lockfile mode, torture-app-replace for lockfile-free + replace). :house: Remote-Dev: homespace
This was referenced Apr 10, 2026
aldoborrero
added a commit
that referenced
this pull request
Apr 13, 2026
Seeds backlog/ with known deferred items for the grind workflow (.claude/commands/grind.md, untracked): - refactor: dead .has_cgo/.has_cxx markers (post-#85) - refactor: pkg/lockfile/ dead-code audit (post-#80/#81/#106) - refactor: filter *_test.go from CLI src so canary doesn't cascade - coverage: pie buildmode fixture - coverage: second dynamic-mode pkg-config fixture - feat: GOFIPS140 snapshot mode (stdlib importcfg remap) - feat: vendor/ directory support - perf: #48 DAG cache revival (blocked, needs-human gate) backlog/tried/ seeded with shipped Tier 1-3 perf work so it's not re-attempted. :house: Remote-Dev: homespace
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
go version -mshowed zerodeplines for lockfile-free builds (goLock = null):link-binaryonly populateddepsfromlockfile.Read(*m.Lockfile), sodebug.BuildInfo.Depswas empty and govulncheck/SBOM tooling saw nothing.linkManifestJSONnow carries amoduleslist (built from the sameallModules+replacementsthatnix/dagalready has from the plugin, regardless of lockfile), andlink-binaryconsumes it directly. The lockfile-read path is removed — the manifest is the actual build set, and the lockfile is still used formvscheck.CheckLockfile.Replacement-target keys are filtered so a fork replace records one
dep+=>line rather than twodeplines.Regression checks
test-fixture-torture-app-replace(lockfile-free, fork replace): assertsdep go.uber.org/atomic v1.11.0+=> github.com/uber-go/atomictest-fixture-testify-basic(lockfile): asserts ≥1depline +dep github.com/stretchr/testifyTest plan
go test ./...(14 pkgs),go vetnix flake check(formatting)