Skip to content

Conversation

@OsirisTerje
Copy link
Member

No description provided.

@SeanKilleen
Copy link
Member

@Arhell curious, why do you approve the PR when the build is failing?

If you are going to approve a PR, it would be really helpful to look at the failing build, see the errors, and suggest changes in a PR review.

@Arhell
Copy link
Member

Arhell commented Nov 13, 2025

@Arhell curious, why do you approve the PR when the build is failing?

If you are going to approve a PR, it would be really helpful to look at the failing build, see the errors, and suggest changes in a PR review.

Thank you, I understand, but I'm making the approved in advance because I'm sure that the errors will be corrected, and according to the document, everything seems to be fine.

@OsirisTerje
Copy link
Member Author

@Arhell I would appreciate commit suggestions when you see errors. In this case it was edited on the web, so I missed those. :-)

@OsirisTerje
Copy link
Member Author

There is something wrong with the branch name, I can't pull it down

@OsirisTerje OsirisTerje merged commit 3d4c600 into master Nov 13, 2025
6 of 7 checks passed
@OsirisTerje OsirisTerje deleted the adapter branch November 13, 2025 12:06
@Arhell
Copy link
Member

Arhell commented Nov 13, 2025

@Arhell I would appreciate commit suggestions when you see errors. In this case it was edited on the web, so I missed those. :-)

Sure

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants