Update cancelafter.md to clarify cancellation token usage#1144
Merged
SeanKilleen merged 3 commits intomasterfrom Mar 3, 2026
Merged
Update cancelafter.md to clarify cancellation token usage#1144SeanKilleen merged 3 commits intomasterfrom
SeanKilleen merged 3 commits intomasterfrom
Conversation
Clarify that the cancellation token is available across all execution phases.
Member
|
Note that if the test is cancelled it cannot be used in the teardown. |
Member
Author
|
Thanks! I can add that too |
Clarify the behavior of cancellation tokens in TearDown phases and their implications for cleanup methods.
stevenaw
commented
Mar 2, 2026
Member
Author
|
I think I've captured the behaviour and your recommendations here @manfred-brands . Can you let me know what you think? |
manfred-brands
approved these changes
Mar 2, 2026
Member
manfred-brands
left a comment
manfred-brands
left a comment
There was a problem hiding this comment.
Thanks @stevenaw. Looks good.
SeanKilleen
approved these changes
Mar 3, 2026
github-actions bot
pushed a commit
that referenced
this pull request
Mar 3, 2026
* Update cancelafter.md to clarify cancellation token usage Clarify that the cancellation token is available across all execution phases. * Enhance documentation on cancellation token usage Clarify the behavior of cancellation tokens in TearDown phases and their implications for cleanup methods. * Apply suggestion from @stevenaw e74521d
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clarify that the cancellation token is available across all execution phases.