TeamCity service message should have assembly name as a part of test name. See #669#671
TeamCity service message should have assembly name as a part of test name. See #669#671NikolayPianikov wants to merge 12 commits intonunit:masterfrom
Conversation
|
@chris-smith-zocdoc, could you give me a second code review on this pull request? You are much more familiar with Team City than I am, so I would appreciate your input. Thanks. |
|
@rprouse Sure. |
|
You can see the results of this working in the new TC setup. https://teamcity.jetbrains.com/viewLog.html?buildId=491864&buildTypeId=NUnit_NUnit3_BuildAndTest&tab=testsInfo
|
|
@NikolayPianikov TC is showing 109 new tests, are all of these because of the duplicate name grouping? If I switch the test view to "tests without grouping by name" there are 10 new tests which are the ones you introduced in this PR.
|
|
This looks good to me |
There was a problem hiding this comment.
A bit of code duplication here. Remove this one and then make GetTestAssembly on TestResult internal.
|
Looks good to me too. @NikolayPianikov, can you make the one requested change? I will merge when you are done. |
…t of test name - remove code dup, fix tests ResultReporterTests
…t of test name - add tests to TestUtilityTests
|
@chris-smith-zocdoc, the number of tests increased because we added prefix to test's name - name of assembly. Now we believe tests in different assembly as different tests and not just as the test's double running. You could compare: But when we have similar names of assemblies, it doesn't work as we would like |
|
Note that the Engine tests should not actually be part of the .NET 4.5 run, however. |
There was a problem hiding this comment.
I would prefer to avoid adding this attribute to the XML if possible. Every test is eventually nested under a suite of type "Assembly", which has the full name of the assembly. Putting it on every test is an extreme level of duplication in the result file for all users, even though it is only used for TeamCity.
Also, every test has an id, the first part of which (before the hyphen) identifies the assembly uniquely. It could be considered to use this as a part of the name, perhaps as a prefix, when creating TC messages.
|
I added a line note because I was surprised to see that this PR is changing the framework itself. We anticipated - or at least I did - that it was only a small local change to the Console runner. If we are going to change the output of the framework, we want to give it a careful review. |
Standardize disposal of engine objects. Fixes nunit#673
Refactor framework driver so that no use of XmlNode remains, allowing…
…rt of test name - Add tests
…t of test name - remove code dup, fix tests ResultReporterTests
…t of test name - add tests to TestUtilityTests
…olayPianikov/nunit into TeamCityTestNameWithAssembly
4 participants
Fixes #669